-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic positioning #30
Conversation
gh-pages implementation coming soon too, just messed some branching up, gonna fix that if that PR makes it. |
Great work. I'll review this properly soon. One quick question, is the caching of the dom element really necessary? Seems a bit weird. I could probably move the gh-pages branch in the master branch because GitHub now allows you to use the |
It indeed looks strange, i felt like i ran ten-thousand tests until i figured out what was causing call stack overflows.
I don't know about that one, i'd personally prefer a similar project structure as e.g. the official plugin chartist-plugin-threshold and a completely isolated project for gh-pages, just like chartist itselft. But this is just my personal preference, got the file ready, just direct me anywhere. |
Ohh wow, fair enough. Could you add that as a comment in the code? That way other people will also understand that. The |
comment caching measure to prevent a stack overflow; based on #30 (comment)
I think that should explain the circularity problem, right? |
Thanks, just tested it to confirm it works 👍 . Good work! Really appreciate it. Sorry for the delay. |
I'll release this after the docs PR :). |
No problem, thanks! Gonna PR tommorow, code's on another machine. Will PR into |
Adds dynamic positioning via any valid DOM2 Element, as discussed in #28.