Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggle-chosen-legend-options #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

majkelo
Copy link

@majkelo majkelo commented Nov 26, 2017

Added toggling option to the legend

@tarekis
Copy link
Contributor

tarekis commented Nov 27, 2017

Need to review the PR in detail, but I can definitely tell you, you'll need to write tests for your code; as you can see coverage went down :(

@tarekis tarekis added the waiting label Dec 6, 2017
@tarekis
Copy link
Contributor

tarekis commented Dec 6, 2017

@majkelo Any intention to continue on this one?

@majkelo
Copy link
Author

majkelo commented Dec 18, 2017

Yup, I've seen it. Unfortunatelly I won't write them in a reasonable time soon. Sorry!

@tarekis
Copy link
Contributor

tarekis commented Dec 19, 2017

Alright, I don't really have too much time on my hands to maintain this anyways, get back to it when you can and I'll try my best to review it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants