Parcha #139 al incluir componentes sin ámbito #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxcar
reviewed
Jun 14, 2023
| return false | ||
| end | ||
| end | ||
| # @proposal.scope == current_user_scope(@proposal) |
|
Se instaló esta versión sin problemas de webpacker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
En varias partes de la aplicación (vistas, helpers, commands) se asume que todas las propuestas tienen un ámbito.
Este PR corrige eso agregando checks para component.scope.nil y refactorea el método que se usa checar el scope del proceso y devolver el scope correspondiente al usuario.
Se usó el patrón de los Comandos de Rectify que Decidim ya utiliza (aunque esto cambia con la versión 0.27 - ver discusión. En caso de upgrade, esta función debe ajustarse.
De aceptarse este PR, se implementará para decidim-budgets y se refactorizará las vistas asociadas y el helper