Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add i18n setup #184

Merged
merged 7 commits into from
Sep 24, 2017
Merged

WIP: Add i18n setup #184

merged 7 commits into from
Sep 24, 2017

Conversation

thewarpaint
Copy link
Collaborator

@thewarpaint thewarpaint commented Sep 22, 2017

No hacer merge hasta que la nueva branch gh-pages haya sido creada y actualizada, y la configuración de Circle CI haya sido realizada.

Es necesario crear una nueva branch que va a servir el sitio "generado", hacer push del sitio en ese branch, y después mergear el PR. De otro modo, el sitio se rompe. En el script propongo gh-pages pero el nombre no importa, aunque se tiene que actualizar el script si se cambia.

Pruebas realizadas aquí: https://politeiamx.github.io/terremoto-cdmx/
Branch: https://github.com/politeiamx/terremoto-cdmx/tree/gh-pages

@thewarpaint thewarpaint mentioned this pull request Sep 22, 2017
@gabelula gabelula changed the title Add i18n setup WIP: Add i18n setup Sep 23, 2017
- run:
name: Configure git user info
command: |
git config --global user.email "eduardogarcia.xyz+gh@gmail.com"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Podemos cambiar los datos que aparecen aquí si ya tienen algún machine user de GH.


- add_ssh_keys:
fingerprints:
- "84:b8:1c:87:23:48:84:15:b7:64:d9:10:dd:db:c6:ed"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por ahora esta es la SSH key que usé para probar en uno de mis repos, claro que se puede cambiar por otra de su preferencia.

@thewarpaint thewarpaint force-pushed the feature/i18n branch 2 times, most recently from 35e3e40 to 5e065ad Compare September 24, 2017 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants