Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using underlines instead of parenthesis for (P)lay and (B)uild #78

Closed
JoshuaKGoldberg opened this issue Oct 20, 2020 · 1 comment
Closed

Consider using underlines instead of parenthesis for (P)lay and (B)uild #78

JoshuaKGoldberg opened this issue Oct 20, 2020 · 1 comment
Labels
accessibility Related to keeping this WCAG AA accessible ("a11y") good first issue Good for newcomers. Hop onboard! status: accepting prs If you can resolve this issue, please send a PR!

Comments

@JoshuaKGoldberg
Copy link
Collaborator

Is it more standard to use an underline to indicate a shortcut? We think the parenthesis are enough notice (and it's in the aria-label), but as a fun good first issue, this might be a nice little quality of life improvement.
@JoshuaKGoldberg JoshuaKGoldberg added accessibility Related to keeping this WCAG AA accessible ("a11y") good first issue Good for newcomers. Hop onboard! status: accepting prs If you can resolve this issue, please send a PR! labels Oct 20, 2020
@JoshuaKGoldberg
Copy link
Collaborator Author

Closing out my old issues I no longer have context on. If anybody else is still seeing this, I'd encourage you to file a new issue with more information. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility Related to keeping this WCAG AA accessible ("a11y") good first issue Good for newcomers. Hop onboard! status: accepting prs If you can resolve this issue, please send a PR!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg