Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Term entry dart to int() #4578

Merged

Conversation

VivianVanilla
Copy link
Contributor

Description

I simply added a term entry for the .toInt() method by adding a new file located .../type-conversion/toInt/toInt.md. I added an example of how to use the method and followed the style guide and general procedure to the best of my ability. I did this for the Codecademy portfolio assignment in the 'Learn Git and Github' and had more fun than I expected!

Issue Solved

Closes Issue #4570

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2024

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this Apr 26, 2024
@mamtawardhani mamtawardhani added new entry New entry or entries status: under review Issue or PR is currently being reviewed dart Dart entries labels Apr 26, 2024
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VivianVanilla! Thank you for contributing to Codecademy Docs!

The entry is well written! I've provided a few suggestions, could you please review and modify those at your earliest convenience?

Thank you!

content/dart/concepts/type-conversion/toInt/toInt.md Outdated Show resolved Hide resolved
content/dart/concepts/type-conversion/toInt/toInt.md Outdated Show resolved Hide resolved
content/dart/concepts/type-conversion/toInt/toInt.md Outdated Show resolved Hide resolved
content/dart/concepts/type-conversion/toInt/toInt.md Outdated Show resolved Hide resolved
content/dart/concepts/type-conversion/toInt/toInt.md Outdated Show resolved Hide resolved
VivianVanilla and others added 5 commits April 26, 2024 10:19
Co-authored-by: mamtawardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: mamtawardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: mamtawardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: mamtawardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: mamtawardhani <53176352+mamtawardhani@users.noreply.github.com>
@VivianVanilla
Copy link
Contributor Author

Thank you so much for the suggestions and help @mamtawardhani ! I believe I've addressed all your concerns :).

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for second review

@letsbuildanything letsbuildanything self-assigned this Apr 27, 2024
@letsbuildanything letsbuildanything added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Apr 27, 2024
@letsbuildanything letsbuildanything linked an issue Apr 29, 2024 that may be closed by this pull request
3 tasks
@letsbuildanything
Copy link
Collaborator

@VivianVanilla, could you please update the file path to docs/content/dart/concepts/type-conversion/terms/toInt/toInt.md? We've included a terms folder within it.
Apologies for any inconvenience caused by this additional task.

@VivianVanilla
Copy link
Contributor Author

@letsbuildanything Updated the path!

Copy link
Collaborator

@letsbuildanything letsbuildanything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@letsbuildanything letsbuildanything merged commit f445d03 into Codecademy:main Apr 30, 2024
6 checks passed
Copy link

👋 @VivianVanilla
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/dart/type-conversion/toInt

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@letsbuildanything letsbuildanything added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] Dart Type Conversion .toInt()
4 participants