Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .create_gantt entry, associated media and new tags doc #4604

Closed
wants to merge 25 commits into from

Conversation

rgo444
Copy link
Contributor

@rgo444 rgo444 commented May 3, 2024

Description

Added a new term entry for Plotly: .create_gantt(), along with an associated media image of the plot output. I also updated the tags document to include a new tag: Plotly 📍

Issue Solved

Closes #4563

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented May 3, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
9 out of 10 committers have signed the CLA.

✅ rgo444
✅ jesacebar
✅ mamtawardhani
✅ gurpiar03
✅ Vizhou19
✅ joseandersonramos
✅ nateginn
✅ msaf9
✅ 0-Brandon
❌ codecademy-gh-api
You have signed the CLA already but the status is still pending? Let us recheck it.

@mamtawardhani mamtawardhani self-assigned this May 4, 2024
@mamtawardhani mamtawardhani added new entry New entry or entries status: under review Issue or PR is currently being reviewed plotly Python:Plotly entries labels May 4, 2024
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rgo444! Thanks for contributing at Codecademy!

Please do the following:
(1) Sign the CLA
(2) Could you please rename the file to create_gantt.md, instead of create-gantt.md
(3) Please remove the tags.md file from this branch.
(4) I've mentioned some suggestions for the entry, could you please review and modify them at your earliest convenience?

Thank you!

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rgo444! I've suggested some changes in the entry, could you please review those and modify them at your earliest convenience?
Also, you can remove the older create-gantt.md file from this branch, keep only the new create_gantt.md file.

Thanks!

mamtawardhani and others added 16 commits May 7, 2024 17:45
# Added in catalog-content.md:
- Python:Pillow
- Python:Plotly

# Added in tags.md:
- Charts
- Pillow
- Plotly
* Add Python sets issubset() term entry

* Improve some sentences and format in Python issubset() term entry

* Update issubset.md

* Update issubset.md

* Modify descriptions and variable names in issubset() term entry

* Improve grammar of sentence in issubset() term entry

---------
)

* Created new folder and dot.md file also pasted the template into the file.

* added 1st draft content to the dot.md file

* revised content with suggestions from collaborator.

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update dot.md

* Update dot.md

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>

* minor changes and formatting

---------
* First Commit for toString() dart

* Update toString.md

* minor changes

* Updated toString.md

---------
* I add how to use group selector in selectors.md

* Minor changes

* Prettier formating

* Update content/css/concepts/selectors/selectors.md

---------
* Add metadata, introduction and sintax

* Add example and format text

* Add image to media folder and example link

* Update content/plotly/concepts/plotly.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/plotly/concepts/plotly.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/plotly/concepts/plotly.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/plotly/concepts/plotly.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Replace sintaxis for instalation, remove example and picture

* Fix formatting and ran scripts

* Update content/plotly/plotly.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Change plotly.express description

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Change plotly.graph_objects description

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Change plotly.figure_factory description

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Minor changes

---------
* add Julia programming language

* resolve 2 of 2 review comments

* Modified Julia.md

---------
* added columns entry

* added index entry

* minor phrasing changes and typo fixes

* Apply suggestions from review

Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>

* formatting columns.md

* formatting index.md

* Apply changes

Co-authored-by: Avdhoot <50920321+avdhoottt@users.noreply.github.com>

---------
# Added in catalog-content.md:
- Python:Pillow
- Python:Plotly

# Added in tags.md:
- Charts
- Pillow
- Plotly
* Add Python sets issubset() term entry

* Improve some sentences and format in Python issubset() term entry

* Update issubset.md

* Update issubset.md

* Modify descriptions and variable names in issubset() term entry

* Improve grammar of sentence in issubset() term entry

---------
)

* Created new folder and dot.md file also pasted the template into the file.

* added 1st draft content to the dot.md file

* revised content with suggestions from collaborator.

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update dot.md

* Update dot.md

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>

* Update content/numpy/concepts/built-in-functions/terms/dot/dot.md

Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>

* minor changes and formatting

---------
* First Commit for toString() dart

* Update toString.md

* minor changes

* Updated toString.md

---------
* I add how to use group selector in selectors.md

* Minor changes

* Prettier formating

* Update content/css/concepts/selectors/selectors.md

---------
* Add metadata, introduction and sintax

* Add example and format text

* Add image to media folder and example link

* Update content/plotly/concepts/plotly.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/plotly/concepts/plotly.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/plotly/concepts/plotly.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Update content/plotly/concepts/plotly.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Replace sintaxis for instalation, remove example and picture

* Fix formatting and ran scripts

* Update content/plotly/plotly.md

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Change plotly.express description

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Change plotly.graph_objects description

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Change plotly.figure_factory description

Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>

* Minor changes

---------
msaf9 and others added 5 commits May 12, 2024 13:07
* add Julia programming language

* resolve 2 of 2 review comments

* Modified Julia.md

---------
* added columns entry

* added index entry

* minor phrasing changes and typo fixes

* Apply suggestions from review

Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>

* formatting columns.md

* formatting index.md

* Apply changes

Co-authored-by: Avdhoot <50920321+avdhoottt@users.noreply.github.com>

---------
@mamtawardhani
Copy link
Collaborator

Hey @rgo444!
Here's a suggestion, I see that you have added a lot of files for this PR. Could you close this PR and create a new one with the suggestions you modified? That will be easy actually.

And sorry for the inconvenience caused, please make sure the path is docs/content/plotly/concepts/figure-factory/terms/create-gantt/create-gantt.md, so the create-gantt/create-gantt.md folder and file name should be fine.

Thank you!

@rgo444
Copy link
Contributor Author

rgo444 commented May 15, 2024

Dear @mamtawardhani , I'll go ahead and create a new PR for this entry. The correct name would be then the original create-gantt.md? Or I misunderstood?

@mamtawardhani
Copy link
Collaborator

Yes @rgo444, it would be create-gantt.md.
Just make sure you apply the suggestions that I had given! Thanks! :)

@mohitO12-dev mohitO12-dev self-assigned this May 19, 2024
@rgo444 rgo444 closed this by deleting the head repository May 19, 2024
@rgo444
Copy link
Contributor Author

rgo444 commented May 19, 2024

Done deal @mamtawardhani! Have an excellent weekstart!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python Plotly .create_gantt()