Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python plotly bar #4607

Merged
merged 11 commits into from
May 21, 2024
Merged

Python plotly bar #4607

merged 11 commits into from
May 21, 2024

Conversation

M-MacNeill
Copy link
Contributor

Description

Term Entry and example output for Plotly .bar() method. Created docs/content/plotly/concepts/express/terms/bar/bar.md and docs\media\plotly-bar-example.png.

Issue Solved

Closes #4557

Type of Change

  • Adding a new entry
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented May 5, 2024

CLA assistant check
All committers have signed the CLA.

@Sriparno08 Sriparno08 self-assigned this May 5, 2024
@Sriparno08 Sriparno08 added new entry New entry or entries status: under review Issue or PR is currently being reviewed plotly Python:Plotly entries labels May 5, 2024
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @M-MacNeill, thanks for contributing to Codecademy!

I've listed all the modifications that you need to make in your entry below:

content/plotly/concepts/express/terms/bar/bar.md Outdated Show resolved Hide resolved
content/plotly/concepts/express/terms/bar/bar.md Outdated Show resolved Hide resolved
content/plotly/concepts/express/terms/bar/bar.md Outdated Show resolved Hide resolved
content/plotly/concepts/express/terms/bar/bar.md Outdated Show resolved Hide resolved
content/plotly/concepts/express/terms/bar/bar.md Outdated Show resolved Hide resolved
content/plotly/concepts/express/terms/bar/bar.md Outdated Show resolved Hide resolved
content/plotly/concepts/express/terms/bar/bar.md Outdated Show resolved Hide resolved
Co-authored-by: Sriparno Roy <89148144+Sriparno08@users.noreply.github.com>
@M-MacNeill
Copy link
Contributor Author

Thanks for the suggested changes @Sriparno08. I have now applied them.

Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a second review! 👍

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @M-MacNeill! Thanks for contributing to Codecademy Docs!

I've suggested a few changes, could you please review and modify them at your earliest convenience?
Thank you!

content/plotly/concepts/express/terms/bar/bar.md Outdated Show resolved Hide resolved
content/plotly/concepts/express/terms/bar/bar.md Outdated Show resolved Hide resolved
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
@M-MacNeill
Copy link
Contributor Author

@mamtawardhani, Thank you for the additional suggestions. I have now made them too.

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the required changes @M-MacNeill!

The entry looks good to me 👍
Will merge it to the main branch soon!

@mamtawardhani mamtawardhani merged commit 86cdce7 into Codecademy:main May 21, 2024
6 checks passed
Copy link

👋 @M-MacNeill
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/plotly/express/bar

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python Plotly .bar()
4 participants