Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Concept Entry] Python Plotly #4609

Merged
merged 16 commits into from
May 12, 2024

Conversation

joseandersonramos
Copy link
Contributor

@joseandersonramos joseandersonramos commented May 6, 2024

Description

  • Added the Plotly concept for python

Issue Solved

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented May 6, 2024

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this May 6, 2024
@mamtawardhani mamtawardhani added new entry New entry or entries status: under review Issue or PR is currently being reviewed plotly Python:Plotly entries labels May 6, 2024
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @joseandersonramos! Thank you for contributing to the Codecameny Docs!
The entry is well written!

Sorry for the inconvenience caused, the issue mentions that it needs an example block, but I think that is not needed. Please follow the format as follows:
(1) Metadata
(2) A short description of plotly
(3) Installation (You can remove the syntax block and add the installation part as suggested in the entry)
(4) A short description of the Plotly modules (very short). (You can remove the example block and add this).

I have added some suggestions, please review and modify them at your earliest convenience.
Lastly, please update the path to: docs/content/plotly/plotly.md

Thank you!

content/plotly/concepts/plotly.md Outdated Show resolved Hide resolved
content/plotly/concepts/plotly.md Outdated Show resolved Hide resolved
content/plotly/concepts/plotly.md Outdated Show resolved Hide resolved
content/plotly/concepts/plotly.md Outdated Show resolved Hide resolved
content/plotly/concepts/plotly.md Outdated Show resolved Hide resolved
content/plotly/concepts/plotly.md Outdated Show resolved Hide resolved
@joseandersonramos
Copy link
Contributor Author

Hey @joseandersonramos! Thank you for contributing to the Codecameny Docs! The entry is well written!

Sorry for the inconvenience caused, the issue mentions that it needs an example block, but I think that is not needed. Please follow the format as follows: (1) Metadata (2) A short description of plotly (3) Installation (You can remove the syntax block and add the installation part as suggested in the entry) (4) A short description of the Plotly modules (very short). (You can remove the example block and add this).

I have added some suggestions, please review and modify them at your earliest convenience. Lastly, please update the path to: docs/content/plotly/plotly.md

Thank you!

Received!, Thank you for the suggestion!

joseandersonramos and others added 6 commits May 6, 2024 10:01
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @joseandersonramos! I've suggested a few changes in the phrasing, please review and modify those at your earliest convenience.
Thank you!

content/plotly/plotly.md Outdated Show resolved Hide resolved
content/plotly/plotly.md Outdated Show resolved Hide resolved
content/plotly/plotly.md Outdated Show resolved Hide resolved
content/plotly/plotly.md Outdated Show resolved Hide resolved
joseandersonramos and others added 4 commits May 7, 2024 03:42
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
@joseandersonramos
Copy link
Contributor Author

Hello @joseandersonramos! I've suggested a few changes in the phrasing, please review and modify those at your earliest convenience. Thank you!

Done!

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Good for the next review!

@Sriparno08 Sriparno08 added the status: under review Issue or PR is currently being reviewed label May 7, 2024
@Sriparno08 Sriparno08 self-assigned this May 7, 2024
@joseandersonramos
Copy link
Contributor Author

Hello @Sriparno08,
Is there anything else I need to do to with those ci test?

@Sriparno08
Copy link
Collaborator

No, @joseandersonramos. There's nothing needed from your side for now.

@joseandersonramos
Copy link
Contributor Author

No, @joseandersonramos. There's nothing needed from your side for now.

Ok, thank you.

Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @joseandersonramos!

@Sriparno08 Sriparno08 merged commit 22c41b5 into Codecademy:main May 12, 2024
6 checks passed
Copy link

👋 @joseandersonramos
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/plotly

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Concept Entry] Python Plotly
4 participants