Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .discard() method. #4636

Merged
merged 16 commits into from May 15, 2024
Merged

Add .discard() method. #4636

merged 16 commits into from May 15, 2024

Conversation

BeateBB
Copy link
Contributor

@BeateBB BeateBB commented May 9, 2024

Description

I have created the article about the .discard() method for set objects in Python.
It's my first contribution to GitHub, which I'm currently learning on the Codecademy platform.

Issue Solved

Closes #4612

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented May 9, 2024

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this May 9, 2024
@mamtawardhani mamtawardhani added python Python entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels May 9, 2024
@BeateBB BeateBB force-pushed the sets-discard branch 2 times, most recently from 1173476 to df10529 Compare May 10, 2024 13:58
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BeateBB! Thank you for contributing at Codecademy Docs! The entry was well written!

I've suggested some changes in the entry, could you please review and modify those at your earliest convenience? Please feel free to discuss any concerns.
Thank you!

content/python/concepts/sets/terms/discard/discard.md Outdated Show resolved Hide resolved
content/python/concepts/sets/terms/discard/discard.md Outdated Show resolved Hide resolved
content/python/concepts/sets/terms/discard/discard.md Outdated Show resolved Hide resolved
content/python/concepts/sets/terms/discard/discard.md Outdated Show resolved Hide resolved
content/python/concepts/sets/terms/discard/discard.md Outdated Show resolved Hide resolved
content/python/concepts/sets/terms/discard/discard.md Outdated Show resolved Hide resolved
content/python/concepts/sets/terms/discard/discard.md Outdated Show resolved Hide resolved
content/python/concepts/sets/terms/discard/discard.md Outdated Show resolved Hide resolved
content/python/concepts/sets/terms/discard/discard.md Outdated Show resolved Hide resolved
content/python/concepts/sets/terms/discard/discard.md Outdated Show resolved Hide resolved
@BeateBB
Copy link
Contributor Author

BeateBB commented May 11, 2024

Hey, I commited all the changes. I have to improve my knowledge of english) I also suggest to add an article about sets.remove() method to Codecademy Docs and create a link to it.

@mamtawardhani
Copy link
Collaborator

Hey @BeateBB, thank you for the suggestion, we will add the issue for .remove() as well.

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes @BeateBB!

Looks good for a second review.

@BeateBB
Copy link
Contributor Author

BeateBB commented May 11, 2024

What check was not successful? Should I do something?

@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels May 12, 2024
@Sriparno08 Sriparno08 self-assigned this May 12, 2024
BeateBB and others added 10 commits May 15, 2024 07:58
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @BeateBB! 👍

@Sriparno08 Sriparno08 merged commit 99c4b51 into Codecademy:main May 15, 2024
6 checks passed
Copy link

👋 @BeateBB
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/python/sets/discard

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python sets .discard()
4 participants