Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Concept Entry] Postgresql window-functions #4591 #4638

Merged
merged 19 commits into from May 21, 2024

Conversation

Johnnie-kay
Copy link
Contributor

@Johnnie-kay Johnnie-kay commented May 11, 2024

Description

Type of Change

  • Adding a new entry
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented May 11, 2024

CLA assistant check
All committers have signed the CLA.

@SaviDahegaonkar SaviDahegaonkar self-assigned this May 11, 2024
@SaviDahegaonkar SaviDahegaonkar added new entry New entry or entries status: under review Issue or PR is currently being reviewed postgresql PostgreSQL labels May 11, 2024
Copy link
Collaborator

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Author, I have suggested a few changes in the file and corrected some minor mistakes accordingly. Please have a look at it and please let me know.
Thanks!

---

Window functions in PostgreSQL provide an amazing feature that enables computining calculations across sets of rows related to the current row in query. These functions empower you to define rows to operate on based on specific criteria, such as a specific range or grouping.
Window functions are defined using an `OVER` clause that specifies how to partition and order rows for the function to operate on, this clause is what makes the window function different from normal aggregate function.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Window functions are defined using an `OVER` clause that specifies how to partition and order rows for the function to operate on, this clause is what makes the window function different from normal aggregate function.
Window functions are defined using an `OVER` clause that specifies how to partition and order rows for the function to operate on, this clause is what makes the window function different from the normal aggregate function.

@Johnnie-kay
Copy link
Contributor Author

Hello @SaviDahegaonkar, all corrections and suggestions have been attended to.

@mohitO12-dev mohitO12-dev self-assigned this May 19, 2024
Copy link
Contributor Author

@Johnnie-kay Johnnie-kay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the window-functions.md file and made all corrections

@mohitO12-dev mohitO12-dev merged commit cb9674f into Codecademy:main May 21, 2024
6 checks passed
Copy link

👋 @Johnnie-kay
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/postgresql/window-functions
https://github.com/Codecademy/docs/blob/main/documentation/tags.md

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants