Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Topic Entry] MySQL #4665

Merged
merged 4 commits into from
May 21, 2024
Merged

[Topic Entry] MySQL #4665

merged 4 commits into from
May 21, 2024

Conversation

mamtawardhani
Copy link
Collaborator

@mamtawardhani mamtawardhani commented May 17, 2024

Description

Added a Topic Entry for MySQL

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@cigar-galaxy82 cigar-galaxy82 self-assigned this May 17, 2024
@cigar-galaxy82 cigar-galaxy82 added sql SQL entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels May 17, 2024
@cigar-galaxy82
Copy link
Collaborator

Hey @mamtawardhani
Thank you for contributing to Codecademy Docs! The entry is well written!

I've suggested a few changes modify them at your convenience

Thank you!

Co-authored-by: shantanu <56212958+cigar-galaxy82@users.noreply.github.com>
@mamtawardhani
Copy link
Collaborator Author

Its done @cigar-galaxy82 👍

@mamtawardhani
Copy link
Collaborator Author

mamtawardhani commented May 18, 2024

@cigar-galaxy82 you need to add the status: ready for next review and remove the status under review label so that it gets assigned to another reviewer for the second review. :)

@cigar-galaxy82 cigar-galaxy82 added status: ready for next review and removed status: under review Issue or PR is currently being reviewed labels May 18, 2024
@Sriparno08 Sriparno08 self-assigned this May 18, 2024
@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels May 18, 2024
@Sriparno08 Sriparno08 added mysql MySQL and removed sql SQL entries labels May 21, 2024
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @mamtawardhani! 👍

@Sriparno08 Sriparno08 merged commit f1c2f20 into Codecademy:main May 21, 2024
6 checks passed
Copy link

👋 @mamtawardhani
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/mysql

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants