-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request for Julia variables #4667
Conversation
Hey @msaf9! I don't see an issue raised for this particular PR. Could you please link the issue here for which you have submitted this PR? |
Hello @mamtawardhani, it's a typo that I have checked the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @msaf9 thank you for contributing to the Codecademy Docs! The entry was well written!
I've added a few suggestions and requested changes there, could you please review and modify those at your earliest convenience?
(Also, the Constants
and Scoping
can be another term entry, so I've asked to remove them from this. :) )
Thank you! 😄
Hello @mamtawardhani, I have resolved all review comments. Please let me know if there is anything that I should address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for a second review 👍
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Now the branch is upto date, could someone please merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @msaf9! 👍
👋 @msaf9 🎉 Your contribution(s) can be seen here: https://www.codecademy.com/resources/docs/general/julia/variables Please note it may take a little while for changes to become visible. |
Description
Pull request for Julia variables.
Type of Change
Checklist
main
branch.Issues Solved
section.