Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request for Julia variables #4667

Merged
merged 9 commits into from
May 29, 2024
Merged

Pull request for Julia variables #4667

merged 9 commits into from
May 29, 2024

Conversation

msaf9
Copy link
Contributor

@msaf9 msaf9 commented May 18, 2024

Description

Pull request for Julia variables.

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@mamtawardhani
Copy link
Collaborator

Hey @msaf9! I don't see an issue raised for this particular PR. Could you please link the issue here for which you have submitted this PR?

@msaf9
Copy link
Contributor Author

msaf9 commented May 18, 2024

Hello @mamtawardhani, it's a typo that I have checked the Issues Solved section on the Checklist. This is a new entry.

@mamtawardhani mamtawardhani added documentation Improvements or additions to documentation new entry New entry or entries status: under review Issue or PR is currently being reviewed labels May 20, 2024
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @msaf9 thank you for contributing to the Codecademy Docs! The entry was well written!

I've added a few suggestions and requested changes there, could you please review and modify those at your earliest convenience?
(Also, the Constants and Scoping can be another term entry, so I've asked to remove them from this. :) )
Thank you! 😄

@msaf9
Copy link
Contributor Author

msaf9 commented May 21, 2024

Hello @mamtawardhani, I have resolved all review comments. Please let me know if there is anything that I should address.

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a second review 👍

@Sriparno08 Sriparno08 self-assigned this May 21, 2024
@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review documentation Improvements or additions to documentation labels May 21, 2024
msaf9 and others added 7 commits May 21, 2024 15:01
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
@msaf9
Copy link
Contributor Author

msaf9 commented May 21, 2024

Now the branch is upto date, could someone please merge it.

Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @msaf9! 👍

@Sriparno08 Sriparno08 merged commit 450e10f into Codecademy:main May 29, 2024
6 checks passed
Copy link

👋 @msaf9
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/general/julia/variables

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants