-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Term entry difference update py 4617 #4668
Term entry difference update py 4617 #4668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JenHunnisett! Thank you for contributing to the Codecademy Docs! The entry is well written!
I've added suggestions at some places for this entry, could you please review and modify those at your earliest convenience?
Thank you! 😄
content/python/concepts/sets/terms/difference-update/difference-update.md
Outdated
Show resolved
Hide resolved
content/python/concepts/sets/terms/difference-update/difference-update.md
Outdated
Show resolved
Hide resolved
content/python/concepts/sets/terms/difference-update/difference-update.md
Outdated
Show resolved
Hide resolved
content/python/concepts/sets/terms/difference-update/difference-update.md
Outdated
Show resolved
Hide resolved
content/python/concepts/sets/terms/difference-update/difference-update.md
Outdated
Show resolved
Hide resolved
content/python/concepts/sets/terms/difference-update/difference-update.md
Show resolved
Hide resolved
content/python/concepts/sets/terms/difference-update/difference-update.md
Outdated
Show resolved
Hide resolved
content/python/concepts/sets/terms/difference-update/difference-update.md
Outdated
Show resolved
Hide resolved
content/python/concepts/sets/terms/difference-update/difference-update.md
Outdated
Show resolved
Hide resolved
content/python/concepts/sets/terms/difference-update/difference-update.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
…e-update.md Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
…e-update.md Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
@mamtawardhani thank you for your review of my work, it was very helpful :-) I think I have reviewed and committed all but one of your suggestions, and that one I just couldn't see what the difference was, apologies if I'm being obtuse! I'm also new to using github so please let me know if I've made any mistakes in the way I've used it. Thankyou! J |
content/python/concepts/sets/terms/difference-update/difference-update.md
Outdated
Show resolved
Hide resolved
@JenHunnisett no worries at all, happy to help! That one suggestion left means that line can be removed. |
…e-update.md Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
@mamtawardhani I think I have incorporated all your suggested changes now :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the required changes @JenHunnisett! 😄
The entry looks good for the second review 👍
@Sriparno08 let me know if you need anything from me :-) thankyou! |
There's nothing needed from your side as of now, @JenHunnisett. If needed, I'll let you know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @JenHunnisett! 👍
👋 @JenHunnisett 🎉 Your contribution(s) can be seen here: https://www.codecademy.com/resources/docs/python/sets/difference-update Please note it may take a little while for changes to become visible. |
Description
This is a new term entry for the '.difference_update()' method for Sets in Python. The entry is in a new file under docs/content/python/concepts/sets/terms/difference-update/difference-update.md
The entry includes the following:
My motivation to do this is I'm trying to brush up my rusty coding skills, so I've been learning python on the codecademy data science foundations course, wanted to start contributing to OS projects, and then realised I'd only really used git with SVN in the past, so decided to do the codecademy git & github course, which contains a mini project to make a contribution to the docs!
Issue Solved
Closes #4617
Type of Change
Checklist
main
branch.Issues Solved
section.