Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the [Term Entry]-Python sets .disjoint() #4670

Merged
merged 21 commits into from
May 21, 2024
Merged

Added the [Term Entry]-Python sets .disjoint() #4670

merged 21 commits into from
May 21, 2024

Conversation

ULTRAPAIN
Copy link
Contributor

Added the .isdisjoint() method.

Namaste Hand Movement T-Shirt

Description

I have created disjoint/disjoint.md file as mentioned in the Issue which gives info about .isdisjoint() method of python sets.

Issue Solved

Closes #4619

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.

@ULTRAPAIN
Copy link
Contributor Author

@mamtawardhani I have linked the PR please Review It

@Sriparno08 Sriparno08 self-assigned this May 19, 2024
@Sriparno08 Sriparno08 added python Python entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels May 19, 2024
Sriparno08
Sriparno08 requested changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ULTRAPAIN, thanks for contributing to Codecademy!

I've listed all the modifications that you need to make in your entry below:

content/python/concepts/sets/terms/isdisjoint/isdisjoint.md Outdated Show resolved Hide resolved
content/python/concepts/sets/terms/isdisjoint/isdisjoint.md Outdated Show resolved Hide resolved
content/python/concepts/sets/terms/isdisjoint/isdisjoint.md Outdated Show resolved Hide resolved
content/python/concepts/sets/terms/isdisjoint/isdisjoint.md Outdated Show resolved Hide resolved
content/python/concepts/sets/terms/isdisjoint/isdisjoint.md Outdated Show resolved Hide resolved
content/python/concepts/sets/terms/isdisjoint/isdisjoint.md Outdated Show resolved Hide resolved
ULTRAPAIN and others added 6 commits May 20, 2024 21:39
@ULTRAPAIN @Sriparno08
Update content/python/concepts/sets/terms/isdisjoint/isdisjoint.md
95f3618 
Co-authored-by: Sriparno Roy <89148144+Sriparno08@users.noreply.github.com>
@ULTRAPAIN @Sriparno08
Update content/python/concepts/sets/terms/isdisjoint/isdisjoint.md
85d7ba4 
Co-authored-by: Sriparno Roy <89148144+Sriparno08@users.noreply.github.com>
@ULTRAPAIN @Sriparno08
Update content/python/concepts/sets/terms/isdisjoint/isdisjoint.md
78238b0 
Co-authored-by: Sriparno Roy <89148144+Sriparno08@users.noreply.github.com>
@ULTRAPAIN @Sriparno08
Update content/python/concepts/sets/terms/isdisjoint/isdisjoint.md
2262aba 
Co-authored-by: Sriparno Roy <89148144+Sriparno08@users.noreply.github.com>
@ULTRAPAIN @Sriparno08
Update content/python/concepts/sets/terms/isdisjoint/isdisjoint.md
08ae418 
Co-authored-by: Sriparno Roy <89148144+Sriparno08@users.noreply.github.com>
@ULTRAPAIN @Sriparno08
Update content/python/concepts/sets/terms/isdisjoint/isdisjoint.md
75abfa1 
Co-authored-by: Sriparno Roy <89148144+Sriparno08@users.noreply.github.com>
@ULTRAPAIN ULTRAPAIN requested a review from Sriparno08 May 20, 2024 16:18
Sriparno08
Sriparno08 approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a second review! 👍

@mamtawardhani mamtawardhani self-assigned this May 20, 2024
@mamtawardhani mamtawardhani added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels May 20, 2024
mamtawardhani
mamtawardhani approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ready to merge 👍

@mamtawardhani mamtawardhani merged commit 77e5c3a into Codecademy:main May 21, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

👋 @ULTRAPAIN
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/python/sets/isdisjoint

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamtawardhani mamtawardhani mamtawardhani approved these changes

@Sriparno08 Sriparno08 Sriparno08 approved these changes

Assignees

@mamtawardhani mamtawardhani

@Sriparno08 Sriparno08

Labels
new entry New entry or entries python Python entries status: review 1️⃣ completed status: under review Issue or PR is currently being reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python sets .disjoint()
3 participants
@ULTRAPAIN @mamtawardhani @Sriparno08