Add general entry NFT #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dusch4593
added
general
SSwiniarski
requested changes
Dec 18, 2021
There was a problem hiding this comment.
@EugeneGohh, I've done the first review of your PR. There are some edit suggestions. Resolve them and we can go on to the second review.
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
sonnynomnom
reviewed
Dec 20, 2021
sonnynomnom
reviewed
Dec 20, 2021
sonnynomnom
reviewed
Dec 20, 2021
sonnynomnom
reviewed
Dec 20, 2021
yangc95
reviewed
Dec 20, 2021
yangc95
reviewed
Dec 21, 2021
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
yangc95
approved these changes
Dec 23, 2021
Dusch4593
reviewed
Dec 26, 2021
Dusch4593
reviewed
Dec 26, 2021
Dusch4593
reviewed
Dec 26, 2021
Dusch4593
reviewed
Dec 26, 2021
Dusch4593
suggested changes
Dec 26, 2021
There was a problem hiding this comment.
Hi @EugeneGohh! I added a few comments/suggestions for you to look over. After you're finished, let us know and we should be ready to merge! 😄
- Remove usage of "you" - Enhancement to wording Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Dusch4593
approved these changes
Dec 29, 2021
There was a problem hiding this comment.
@yangc95 @SSwiniarski LGTM! Gonna merge and take another look once the changes go live.
|
Congrats @EugeneGohh! 🎉 🎊 🎈 Your contribution is now live on Docs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add general entry NFT. Refer #218 .
Type of Change
Checklist
mainbranch.