Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sql procedures #485

Merged
merged 17 commits into from
Dec 30, 2021
Merged

Sql procedures #485

merged 17 commits into from
Dec 30, 2021

Conversation

SSwiniarski
Copy link
Collaborator

Description

Create SQL Procedures entry.

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.

@SSwiniarski SSwiniarski added sql SQL entries new entry New entry or entries labels Dec 24, 2021
@SSwiniarski SSwiniarski linked an issue Dec 24, 2021 that may be closed by this pull request
@yangc95 yangc95 self-assigned this Dec 27, 2021
Copy link
Contributor

@yangc95 yangc95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SSwiniarski Review 1️⃣ done! I also saw that some favor object-relational mapping to stored procedures. I'm wondering if this is something that can be mentioned or sourced out to for another docs entry. I also understand if this is out-of-scope in which case we can just save it entirely for another entry.

content/sql/concepts/procedures/procedures.md Outdated Show resolved Hide resolved
content/sql/concepts/procedures/procedures.md Outdated Show resolved Hide resolved
content/sql/concepts/procedures/procedures.md Outdated Show resolved Hide resolved
content/sql/concepts/procedures/procedures.md Outdated Show resolved Hide resolved
content/sql/concepts/procedures/procedures.md Outdated Show resolved Hide resolved
content/sql/concepts/procedures/procedures.md Show resolved Hide resolved
SSwiniarski and others added 6 commits December 30, 2021 14:16
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
@SSwiniarski
Copy link
Collaborator Author

SSwiniarski commented Dec 30, 2021

@yangc95, I applied most of your suggestions. I think object-relational mapping belongs in its own entry.

Copy link
Collaborator

@caupolicandiaz caupolicandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of small suggested edits

content/sql/concepts/procedures/procedures.md Outdated Show resolved Hide resolved
content/sql/concepts/procedures/procedures.md Outdated Show resolved Hide resolved
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
@SSwiniarski
Copy link
Collaborator Author

Done with the new comments, @caupolicandiaz, @yangc95.

@yangc95 yangc95 merged commit 3731725 into Codecademy:main Dec 30, 2021
@yangc95
Copy link
Contributor

yangc95 commented Dec 31, 2021

Whoop whoop @SSwiniarski live here: https://www.codecademy.com/resources/docs/sql/procedures

Thanks ya'll 😄 I added some extra spacing to the code block and merged 3731725

cc: @caupolicandiaz

@SSwiniarski SSwiniarski deleted the sql-procedures branch August 10, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL entry needed: Procedures
4 participants