Possible fix for a 'selectOption' issue (#408)

* No longer cycles through different options - just selects the first one. * Fixed to pass existing tests and added a new test requiring changes. * Tidied up the new test. * More tidying of new test.
codeceptjs · Feb 25, 2017 · 2cee168 · 2cee168
1 parent 4b5c8ed
commit 2cee168
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 0 deletions.
diff --git a/lib/helper/Nightmare.js b/lib/helper/Nightmare.js
@@ -651,7 +651,12 @@ class Nightmare extends Helper {
       el = codeceptjs.fetchElement(el);
       let found = document.evaluate(locator, el, null, 5);
       var current = null;
+      var items = [];
       while (current = found.iterateNext()) {
+        items.push(current);
+      }
+      for (var i = 0; i < items.length; items++) {
+        current = items[i];
         current.selected = true;
         var event = document.createEvent('HTMLEvents');
         if (!el.multiple) el.value = current.value;

diff --git a/test/data/app/view/form/select_onchange.php b/test/data/app/view/form/select_onchange.php
@@ -0,0 +1,29 @@
+<html>
+<body>
+<form action="/form/complex" method="POST">
+    <label>
+      <div>Select a value:</div>
+      <div>
+        <select name="select" id="select">
+            <option value=""></option>
+            <option value="option1">Option 1</option>
+            <option value="option2">Option 2</option>
+            <option value="option3">Option 3</option>
+        </select>
+      </div>
+    </label>
+    <input id="submit" disabled="disabled" type="submit" value="Submit" />
+</form>
+<script>
+  document.getElementById('select').addEventListener('change', function() {
+    var submit = document.getElementById('submit');
+    if (this.value === "") {
+      submit.setAttributeNode("disabled", "disabled");
+    } else {
+      var disabled = submit.getAttributeNode("disabled");
+      submit.removeAttributeNode(disabled);
+    }
+  });
+</script>
+</body>
+</html>
diff --git a/test/helper/webapi.js b/test/helper/webapi.js
@@ -219,6 +219,13 @@ module.exports.tests = function() {
       return assert.equal(formContents('age'), 'adult');
     });
 
+    it('should select option by label and option text - with an onchange callback', function*() {
+      yield I.amOnPage('/form/select_onchange');
+      yield I.selectOption('Select a value', 'Option 2');
+      yield I.click('Submit');
+      return assert.equal(formContents('select'), 'option2');
+    });
+
     it('should select multiple options', function*() {
       yield I.amOnPage('/form/select_multiple');
       yield I.selectOption('What do you like the most?', ['Play Video Games', 'Have Sex']);