Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements uncheckOption in WebDriverIO #856

Merged
merged 4 commits into from
Jan 12, 2018
Merged

Implements uncheckOption in WebDriverIO #856

merged 4 commits into from
Jan 12, 2018

Conversation

brunobg
Copy link
Contributor

@brunobg brunobg commented Jan 4, 2018

PR for this issue: #853

Code is extremely similar to checkOption(). I included docs but not tests.

Copy link
Contributor

@DavertMik DavertMik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but documentation is pointing to incorrect file

@@ -649,6 +649,24 @@ class WebDriverIO extends Helper {
return this.browser[clickMethod](elem.ELEMENT);
}

/**
* {{> ../webapi/checkOption }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncheckOption should be here

@brunobg
Copy link
Contributor Author

brunobg commented Jan 10, 2018

Sorry, doc is now fixed.

@codeceptjs codeceptjs deleted a comment Jan 10, 2018
@DavertMik
Copy link
Contributor

Thanks!

@DavertMik DavertMik merged commit 61a2461 into codeceptjs:master Jan 12, 2018
@brunobg brunobg deleted the patch-1 branch January 12, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants