add checkbox name attrbitute support

Codeception · Dec 19, 2016 · 17b1db9 · 17b1db9
1 parent 486eb01
commit 17b1db9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Codeception/Module/WebDriver.php b/src/Codeception/Module/WebDriver.php
@@ -1244,7 +1244,7 @@ protected function findCheckable($context, $radioOrCheckbox, $byValue = false)
         } else {
             $xpath = Locator::combine(
                 // @codingStandardsIgnoreStart
-                "//input[@type = 'checkbox' or @type = 'radio'][(@id = //label[contains(normalize-space(string(.)), $locator)]/@for) or @placeholder = $locator]",
+                "//input[@type = 'checkbox' or @type = 'radio'][(@id = //label[contains(normalize-space(string(.)), $locator)]/@for) or @placeholder = $locator or @name = $locator]",
                 // @codingStandardsIgnoreEnd
                 "//label[contains(normalize-space(string(.)), $locator)]//input[@type = 'radio' or @type = 'checkbox']"
             );

diff --git a/tests/unit/Codeception/Module/TestsForWeb.php b/tests/unit/Codeception/Module/TestsForWeb.php
@@ -216,6 +216,15 @@ public function testCheckboxByCss()
         $this->assertEquals('agree', $form['terms']);
     }
 
+    public function testCheckboxByName()
+    {
+        $this->module->amOnPage('/form/checkbox');
+        $this->module->checkOption('terms');
+        $this->module->click('Submit');
+        $form = data::get('form');
+        $this->assertEquals('agree', $form['terms']);
+    }
+
     public function testCheckboxByLabel()
     {
         $this->module->amOnPage('/form/checkbox');