Skip to content

Commit

Permalink
Declare module dependencies in require-dev (#5772)
Browse files Browse the repository at this point in the history
They must be very loose and have stability set to dev
because they are circular dependencies and stricter rules would make branch builds of those modules fail.
If we need to add some restrictions in the future, they must be added as conflicts
  • Loading branch information
Naktibalda committed Dec 3, 2019
1 parent 97f3176 commit f320b27
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 13 deletions.
6 changes: 0 additions & 6 deletions .travis.yml
Expand Up @@ -34,12 +34,6 @@ before_install:
- composer global require hirak/prestissimo
install:
- '[[ -z "$CI_USER_TOKEN" ]] || composer config github-oauth.github.com ${CI_USER_TOKEN};'
- composer require --no-update codeception/module-asserts:"dev-master"
- composer require --no-update codeception/module-cli:"dev-master"
- composer require --no-update codeception/module-db:"dev-master"
- composer require --no-update codeception/module-filesystem:"dev-master"
- composer require --no-update codeception/module-phpbrowser:"dev-master"
- composer require --no-update codeception/util-universalframework:"dev-master"
- composer install
before_script:
# starting demo server
Expand Down
6 changes: 0 additions & 6 deletions appveyor.yml
Expand Up @@ -34,12 +34,6 @@ install:
- SET PATH=C:\tools\php71;%PATH%
- cd %APPVEYOR_BUILD_FOLDER%
- appveyor DownloadFile https://getcomposer.org/composer.phar
- php composer.phar require --no-update codeception/module-asserts:"dev-master"
- php composer.phar require --no-update codeception/module-cli:"dev-master"
- php composer.phar require --no-update codeception/module-db:"dev-master"
- php composer.phar require --no-update codeception/module-filesystem:"dev-master"
- php composer.phar require --no-update codeception/module-phpbrowser:"dev-master"
- php composer.phar require --no-update codeception/util-universalframework:"dev-master"
- php composer.phar install --prefer-dist -n --no-ansi

test_script:
Expand Down
8 changes: 7 additions & 1 deletion composer.json
Expand Up @@ -28,7 +28,13 @@
"symfony/css-selector": ">=2.7 <6.0",
"behat/gherkin": "^4.4.0",
"codeception/phpunit-wrapper": ">6.0.15 <6.1.0 | ^6.6.1 | ^7.7.1 | ^8.1.0",
"codeception/stub": "^2.0 | ^3.0"
"codeception/stub": "^2.0 | ^3.0",
"codeception/module-asserts": "*@dev",
"codeception/module-cli": "*@dev",
"codeception/module-db": "*@dev",
"codeception/module-filesystem": "*@dev",
"codeception/module-phpbrowser": "*@dev",
"codeception/util-universalframework": "*@dev"
},
"require-dev": {
"monolog/monolog": "~1.8",
Expand Down

0 comments on commit f320b27

Please sign in to comment.