Symfony::extractRawRoles() failed on security collector from Symfony >= 3.3 #4309
Conversation
…>= 3.3. When extracting roles from security collector, you can simply utilize the getValue method of Data class, when it exists.
src/Codeception/Module/Symfony.php
Outdated
| // prior to Symfony 3.3 | ||
| if (method_exists($data, 'getValue')) { | ||
| $roles = $data->getValue(); | ||
| } |
There was a problem hiding this comment.
Expected 1 space after closing brace; newline found
src/Codeception/Module/Symfony.php
Outdated
| @@ -521,9 +521,15 @@ protected function debugResponse($url) | |||
| */ | |||
| private function extractRawRoles(Data $data) | |||
| { | |||
| $raw = $data->getRawData(); | |||
| // prior to Symfony 3.3 | |||
There was a problem hiding this comment.
Are you sure that this comment is correct?
getRawData method is deprecated since 3.3 and removed in 4.0.
|
@Naktibalda I didn't submitted an issue for this PR but it looks like this may fix #4306 as well. Everytime a user is somehow authenticated (even with an AnonymousToken) this branch of the |
src/Codeception/Module/Symfony.php
Outdated
| * | ||
| * @return bool | ||
| */ | ||
| private function dataIsFromSymfony3_3(Data $data): bool |
There was a problem hiding this comment.
Method name Symfony::dataIsFromSymfony3_3 is not in camel caps format
src/Codeception/Module/Symfony.php
Outdated
| * | ||
| * @return bool | ||
| */ | ||
| private function dataIsFromSymfony33(Data $data) |
There was a problem hiding this comment.
I don't like this name because it will be confusing when Symfony 4.0 comes out.
There was a problem hiding this comment.
I'm with you...
There are only two hard things in Computer Science: cache invalidation and naming things. -- Phil Karlton
Made the name a little more generic
|
@Naktibalda @Basster Confirmed, this fixes #4306 . |
…om any Symfony version
When extracting roles from security collector, you can simply utilize the getValue method of Data class, when it exists.