Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2052, changed checkOption method to check all options #2166

Closed

Conversation

cf-pkeating
Copy link

This is a suggested enhancement for PhpBrowser's checkOption method, which retrieves all nodes matched by the $option parameter and then ticks each one individually. The checkOption method currently finds the first checkbox matched by $option and then ticks it. This method is intended to check all checkboxes matched by $option.

@DavertMik
Copy link
Member

Build is failing. Please try to run PhpBrowser or Framework tests locally and try to fix them

@zbateson
Copy link
Member

Hi @pkeatingcrossflow

Thanks for the contribution - yes, it makes things much easier if you test locally first. There's documentation in tests/README.md explaining how.

I think the problem you're having is you're using match() instead of getFieldByLabelOrCss. Also, I would recommend modifying 'proceedCheckOption' itself instead of in checkOption. This will make it work the same for both checkOption and uncheckOption.

@Naktibalda
Copy link
Member

I am closing this pull request because issues weren't fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants