New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InnerBrowser] Submit default values of checkboxes #4411

Merged
merged 2 commits into from Jul 30, 2017

Conversation

Projects
None yet
2 participants
@guidocella
Contributor

guidocella commented Jul 20, 2017

Currently if you use submitForm in functional tests passing a checkbox with the value of true and that checkbox doesn't have a value attribute in the HTML page, that field will have the value of an empty string in the resulting request because setCheckboxBoolValues just gets the value attribute of checkboxes. This pull request modifies it to check if the checkbox does have a value attribute, and if it doesn't it uses "on" as value.

@guidocella guidocella changed the title from [PhpBrowser] Submit default values of checkboxes to [PhpBrowser][Frameworks] Submit default values of checkboxes Jul 20, 2017

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Jul 20, 2017

Member

Thanks. Looks good to me

Member

DavertMik commented Jul 20, 2017

Thanks. Looks good to me

@guidocella guidocella changed the title from [PhpBrowser][Frameworks] Submit default values of checkboxes to [InnerBrowser] Submit default values of checkboxes Jul 27, 2017

@DavertMik DavertMik merged commit 1c7d7d6 into Codeception:2.3 Jul 30, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details

@guidocella guidocella deleted the guidocella:submit-checkboxes-default-value branch Aug 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment