[InnerBrowser] Submit default values of checkboxes #4411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidocella
changed the title
DavertMik
approved these changes
Jul 20, 2017
|
Thanks. Looks good to me |
guidocella
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you use
submitFormin functional tests passing a checkbox with the value of true and that checkbox doesn't have a value attribute in the HTML page, that field will have the value of an empty string in the resulting request becausesetCheckboxBoolValuesjust gets the value attribute of checkboxes. This pull request modifies it to check if the checkbox does have a value attribute, and if it doesn't it uses "on" as value.