Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add click by button title #4586

Merged
merged 1 commit into from Oct 25, 2017
Merged

add click by button title #4586

merged 1 commit into from Oct 25, 2017

Conversation

gimler
Copy link
Contributor

@gimler gimler commented Oct 23, 2017

Make it possible to click on a button by title. For example when you have a form button with only a font icon

<button type="submit" class="btn btn-default" title="save">
  <i class="fa fa-save"></i>
</button>

@DavertMik
Copy link
Member

Hey, good idea.
Is the title a valid attribute for button?

@gimler
Copy link
Contributor Author

gimler commented Oct 24, 2017

@DavertMik
Copy link
Member

DavertMik commented Oct 24, 2017

Thanks, however some tests are failing. I will restart the build on CI but maybe you will need to look at it.
Please try to fix

tests/web/WebDriverTest.php:testClickHashLink
tests/web/WebDriverTest.php:testClickHashButton

@gimler
Copy link
Contributor Author

gimler commented Oct 25, 2017

@DavertMik tests fixed

@DavertMik
Copy link
Member

Thank you! Good job! 👍

@DavertMik DavertMik merged commit 3150e64 into Codeception:2.3 Oct 25, 2017
@gimler gimler deleted the button_title branch October 26, 2017 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants