New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add click by button title #4586

Merged
merged 1 commit into from Oct 25, 2017

Conversation

Projects
None yet
2 participants
@gimler
Contributor

gimler commented Oct 23, 2017

Make it possible to click on a button by title. For example when you have a form button with only a font icon

<button type="submit" class="btn btn-default" title="save">
  <i class="fa fa-save"></i>
</button>
@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Oct 23, 2017

Member

Hey, good idea.
Is the title a valid attribute for button?

Member

DavertMik commented Oct 23, 2017

Hey, good idea.
Is the title a valid attribute for button?

@gimler

This comment has been minimized.

Show comment
Hide comment
@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Oct 24, 2017

Member

Thanks, however some tests are failing. I will restart the build on CI but maybe you will need to look at it.
Please try to fix

tests/web/WebDriverTest.php:testClickHashLink
tests/web/WebDriverTest.php:testClickHashButton

Member

DavertMik commented Oct 24, 2017

Thanks, however some tests are failing. I will restart the build on CI but maybe you will need to look at it.
Please try to fix

tests/web/WebDriverTest.php:testClickHashLink
tests/web/WebDriverTest.php:testClickHashButton

@gimler

This comment has been minimized.

Show comment
Hide comment
@gimler

gimler Oct 25, 2017

Contributor

@DavertMik tests fixed

Contributor

gimler commented Oct 25, 2017

@DavertMik tests fixed

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Oct 25, 2017

Member

Thank you! Good job! 👍

Member

DavertMik commented Oct 25, 2017

Thank you! Good job! 👍

@DavertMik DavertMik merged commit 3150e64 into Codeception:2.3 Oct 25, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details

@gimler gimler deleted the gimler:button_title branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment