-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amqp interop based module. #4624
Conversation
public function _initialize() | ||
{ | ||
$factoryClass = $this->config['factory_class']; | ||
if ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected 0 spaces after opening bracket; newline found
'vhost' => $this->config['vhost'], | ||
]); | ||
|
||
$this->context = $factory->createContext();; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each PHP statement must be on a line by itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double semicolon
Do we really need another? Yes, this one can be more stable and have fewer bugs but who knows? What you can do:
|
This PR was meant to be a replacement for current AMQP module. I don't touch the current one to make a transition simpler. The plan is
So, in the end, you have only one module. |
Yeah, but I planned to remove AMQP module completely from the core - that's the plan. |
👍 |
The PR add another AMQP module but based on AMQP interop. I tried to keep the module as close as possible to currently existing so It might be a replacement for it in future.
There are several reasons for that:
cleaner OO API.