Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing gracefully if webDriver is not hydrated in Recorder extension #5235

Merged
merged 1 commit into from Oct 18, 2018
Merged

Failing gracefully if webDriver is not hydrated in Recorder extension #5235

merged 1 commit into from Oct 18, 2018

Conversation

OneEyedSpaceFish
Copy link
Contributor

See #5221 (comment)
Parent issue: #5177

@OneEyedSpaceFish
Copy link
Contributor Author

Correct me if I'm wrong, but that build failure is not related to the change.

@DavertMik
Copy link
Member

Thanks! The fix looks good and tests pass

@DavertMik DavertMik merged commit bdc85bb into Codeception:2.5 Oct 18, 2018
@OneEyedSpaceFish
Copy link
Contributor Author

Thanks for you effort looking into this massive saga of changes as well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OneEyedSpaceFish @DavertMik @Sir-G