Bugfix issue #5163 #5236
Merged
Bugfix issue #5163 #5236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamMousa
reviewed
Oct 17, 2018
src/Codeception/Step.php
Outdated
| @@ -173,7 +174,7 @@ protected function getClassName($argument) | |||
| { | |||
| if ($argument instanceof \Closure) { | |||
| return 'Closure'; | |||
| } elseif ((isset($argument->__mocked))) { | |||
| } elseif (in_array(MockObject::class, class_implements(get_class($argument)))) { | |||
SamMousa
reviewed
Oct 17, 2018
Nitpick-CI
reviewed
Oct 17, 2018
Fix suggestion commit
|
LGTM, will merge when tests finish. |
|
New github feature is cool but it seems they have a bug :) |
DavertMik
requested changes
Oct 18, 2018
| @@ -173,7 +174,7 @@ protected function getClassName($argument) | |||
| { | |||
| if ($argument instanceof \Closure) { | |||
| return 'Closure'; | |||
| } elseif ((isset($argument->__mocked))) { | |||
| } elseif ($argument instanceof MockObject) { | |||
| return $this->formatClassName($argument->__mocked); | |||
There was a problem hiding this comment.
Ok, what if there is no __mocked property but an object is still MockObject?
There was a problem hiding this comment.
@DavertMik Have applied changes as requested but AppVeyor build failed (it looks like AppVeyor error)
elseif ($argument instanceof MockObject && isset($argument->__mocked) are you happy with this?
|
Please don't mark the PR with [Yii] if it's not Yii related. |
|
I think the better way is to remove |
|
@DavertMik Below is the AppVeyor error. Is there a way to re-trigger the build? |
|
Sorry, not familiar with AppVeyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DavertMik Are you able to have a look at this and review? I understand @SamMousa suggested removing
__mockedproperty but not sure if that's would be an "easy fix", so just checking if class is implementingPHPUnit\Framework\MockObject\MockObjectinterface.Closes #5163