Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REST] Short API responses in debug mode #5455

Merged
merged 4 commits into from Apr 5, 2019

Conversation

Projects
None yet
4 participants
@sebastianneubert
Copy link
Contributor

commented Mar 28, 2019

  • add a new config shortDebugResponse to limit large API responses at CLI in REST module
Show resolved Hide resolved src/Codeception/Module.php Outdated
Sebastian N
@Naktibalda
Copy link
Member

left a comment

Thanks for raising a pull request.
Could you make a few changes?

Show resolved Hide resolved src/Codeception/Module.php Outdated
Show resolved Hide resolved src/Codeception/Module/REST.php Outdated
Show resolved Hide resolved src/Codeception/Module/REST.php Outdated

Sebastian N added some commits Apr 1, 2019

@sebastianneubert

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

I switch back to "only int params" after getting in trouble of casting bool vars from config into integer. Thanks for reviewing the code.

@sebastianneubert

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

Thanks for raising a pull request.
Could you make a few changes?

I resolved all changes.

@DavertMik

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

Thanks, looks good. Merging!

@DavertMik DavertMik changed the base branch from 2.6 to 2.5 Apr 5, 2019

@DavertMik DavertMik changed the base branch from 2.5 to 2.6 Apr 5, 2019

@DavertMik DavertMik merged commit 78137fb into Codeception:2.6 Apr 5, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.