Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REST] Short API responses in debug mode #5455

Merged
merged 4 commits into from Apr 5, 2019
Merged

[REST] Short API responses in debug mode #5455

merged 4 commits into from Apr 5, 2019

Conversation

sebastianneubert
Copy link
Contributor

  • add a new config shortDebugResponse to limit large API responses at CLI in REST module

Naktibalda
Naktibalda requested changes Mar 28, 2019
View reviewed changes
Copy link
Member

@Naktibalda Naktibalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising a pull request.
Could you make a few changes?

src/Codeception/Module.php Outdated Show resolved Hide resolved
src/Codeception/Module/REST.php Outdated Show resolved Hide resolved
src/Codeception/Module/REST.php Outdated Show resolved Hide resolved
@sebastianneubert
Copy link
Contributor Author

I switch back to "only int params" after getting in trouble of casting bool vars from config into integer. Thanks for reviewing the code.

@sebastianneubert
Copy link
Contributor Author

Thanks for raising a pull request.
Could you make a few changes?

I resolved all changes.

@DavertMik
Copy link
Member

Thanks, looks good. Merging!

@DavertMik DavertMik changed the base branch from 2.6 to 2.5 April 5, 2019 11:51
@DavertMik DavertMik changed the base branch from 2.5 to 2.6 April 5, 2019 11:51
@DavertMik DavertMik merged commit 78137fb into Codeception:2.6 Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavertMik DavertMik DavertMik left review comments

@Nitpick-CI Nitpick-CI Nitpick-CI left review comments

@Naktibalda Naktibalda Naktibalda requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sebastianneubert @DavertMik @Naktibalda @Nitpick-CI