Changed CSS: Remove text-transform: uppercase; #593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TavoNiievez
suggested changes
Jan 10, 2022
.vscode/launch.json
Outdated
Comment on lines
2
to
14
| // Use IntelliSense to learn about possible attributes. | ||
| // Hover to view descriptions of existing attributes. | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "type": "pwa-chrome", | ||
| "request": "launch", | ||
| "name": "Launch Chrome against localhost", | ||
| "url": "http://localhost:8080", | ||
| "webRoot": "${workspaceFolder}" | ||
| } | ||
| ] |
There was a problem hiding this comment.
this file should not be included in git.
| @@ -259,7 +258,6 @@ body { | |||
|
|
|||
| h1:after, h2:after { | |||
| content: '_'; | |||
| color: #236BFD; | |||
There was a problem hiding this comment.
I meant to remove the entire character, not just its color ;-) So please delete this entire rule.
Arhell
reviewed
Jan 10, 2022
There was a problem hiding this comment.
My suggestion is to roll back all the changes. Which corrected affects the entire site.
It only needs to be corrected on the documentation pages.
Add this way:
overwrite styles
.page #page {
....
}
Remove the blue line only in h2, h3, etc.
In h1 it is not necessary, this is a feature of the site.
|
fix #598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I have removed text-transform:uppercase and also I have removed the blue _ in h1:after and h2:after. Please Review my PR.
Thanks!