Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code standards updated to PHP 7.3 #39

Merged
merged 6 commits into from
Jun 7, 2021
Merged

Code standards updated to PHP 7.3 #39

merged 6 commits into from
Jun 7, 2021

Conversation

TavoNiievez
Copy link
Member

@TavoNiievez TavoNiievez commented May 10, 2021 •
edited
Loading

  • The minimum version of PHP is now 7.3, Symfony +4.4
  • Added strict types
  • Added return types
  • Added some typehints
  • Removed unnecessary qualifiers

NEW:

  • AssertSame instead of AssertEquals
  • Support for Codeception 5

@TavoNiievez TavoNiievez requested a review from SamMousa May 10, 2021 00:33
@TavoNiievez TavoNiievez marked this pull request as ready for review May 13, 2021 02:40
Naktibalda
Naktibalda requested changes May 18, 2021
View reviewed changes
src/Codeception/Lib/InnerBrowser.php Outdated Show resolved Hide resolved
src/Codeception/Lib/InnerBrowser.php Outdated Show resolved Hide resolved
src/Codeception/Lib/InnerBrowser.php Outdated Show resolved Hide resolved
src/Codeception/Lib/InnerBrowser.php Outdated Show resolved Hide resolved
src/Codeception/Lib/InnerBrowser.php Outdated Show resolved Hide resolved
src/Codeception/Lib/InnerBrowser.php Outdated Show resolved Hide resolved
@TavoNiievez TavoNiievez changed the title Code standards updated to PHP 7.1 Code standards updated to PHP 7.3 May 28, 2021
TavoNiievez
TavoNiievez commented May 29, 2021
View reviewed changes
composer.json
"ext-dom": "*",
"ext-json": "*",
"ext-mbstring": "*",
"codeception/codeception": "dev-5.0-interfaces",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporary change to demonstrate the proper functioning of the CI

@TavoNiievez TavoNiievez changed the base branch from master to codecept5 June 7, 2021 00:10
@TavoNiievez TavoNiievez merged commit 1f1a533 into Codeception:codecept5 Jun 7, 2021
TavoNiievez added a commit that referenced this pull request Jun 7, 2021
@TavoNiievez
Code standards updated to PHP 7.3 (#39)
987c21b 
* Code standards updated to PHP 7.3
* Support for Codeception 5
* AssertSame instead of AssertEquals
* temporarily use dev branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamMousa SamMousa Awaiting requested review from SamMousa

@Naktibalda Naktibalda Awaiting requested review from Naktibalda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TavoNiievez @Naktibalda