Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code standards updated to PHP 7.1 #7

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Code standards updated to PHP 7.1 #7

merged 2 commits into from
Jun 3, 2021

Conversation

TavoNiievez
Copy link
Member

  • The minimum version of PHP is now 7.1
  • Added strict types
  • Added return types
  • Added typehints
  • Removed unnecessary qualifiers

@TavoNiievez TavoNiievez marked this pull request as ready for review May 13, 2021 02:43
Naktibalda
Naktibalda requested changes May 18, 2021
View reviewed changes
src/Codeception/Module/AMQP.php Outdated Show resolved Hide resolved
@TavoNiievez TavoNiievez changed the base branch from master to php71 June 3, 2021 11:16
@TavoNiievez TavoNiievez merged commit 08ccb5b into Codeception:php71 Jun 3, 2021
@TavoNiievez TavoNiievez deleted the return-types branch June 3, 2021 11:17
TavoNiievez added a commit that referenced this pull request Nov 1, 2021
@TavoNiievez @gnievesj
Code standards updated to PHP 7.1 (#7)
b454378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naktibalda Naktibalda Awaiting requested review from Naktibalda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TavoNiievez @Naktibalda