Remove use of namespace, keep it inline #9
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! :-)
I noticed a change in this module recently that caused our static analyse to return errors as the file generated by Codeception is no longer valid.
In this PR (https://github.com/Codeception/module-asserts/pull/7/files#diff-b3d3622a11b4688b45ee6999ce435bc0L178) a change was introduced that included the
Throwable
andException
class via use instead of having it in the doc block as\Throwable
and\Exception
. Which is fine as the tests still run but when the support files are generated the use statements aren't copied causing the generated files to contain errors in the doc blocks (which continue into our tests, which are analysed for these sort of things).This PR reverts the change of using the namespaces. The tests still work but it looks wrong to have a generated file that isn't correct. Let me know if you need more information or if there's an alternative solution!
Related screenshots from generated file:
This is part of the
_generated/IntegrationTesterActions
. Marked in yellow,Throwable
as undefined class.This is what it used to be, does not contain the undefined class.