Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of namespace, keep it inline #9



Copy link

Hello! :-)

I noticed a change in this module recently that caused our static analyse to return errors as the file generated by Codeception is no longer valid.

In this PR ( a change was introduced that included the Throwable and Exception class via use instead of having it in the doc block as \Throwable and \Exception. Which is fine as the tests still run but when the support files are generated the use statements aren't copied causing the generated files to contain errors in the doc blocks (which continue into our tests, which are analysed for these sort of things).

This PR reverts the change of using the namespaces. The tests still work but it looks wrong to have a generated file that isn't correct. Let me know if you need more information or if there's an alternative solution!

Related screenshots from generated file:

Skjermbilde 2020-08-31 kl  08 57 49
This is part of the _generated/IntegrationTesterActions. Marked in yellow, Throwable as undefined class.

Skjermbilde 2020-08-31 kl  09 10 26
This is what it used to be, does not contain the undefined class.

@Naktibalda Naktibalda merged commit 8f6f75d into Codeception:master Oct 21, 2020
Copy link


@edwinkortman edwinkortman deleted the missing-include-in-generated-files branch October 22, 2020 04:41
Copy link
Contributor Author

Thank you @Naktibalda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants