Merge pull request #13 from Codeception/unset-shell-verbosity

Unset SHELL_VERBOSITY environment variable before execution of command

.github/workflows/main.yml

@@ -8,7 +8,7 @@ jobs:
 
     strategy:
       matrix:
-        php: [7.4, 8.0, 8.1]
+        php: [7.4, 8.0, 8.1, 8.2]
 
     steps:
     - name: Checkout code
@@ -23,8 +23,16 @@ jobs:
     - name: Validate composer.json and composer.lock
       run: composer validate
 
+    - name: Install Codeception 4 on PHP 7.4
+      if: matrix.php == '7.4'
+      run: composer require codeception/codeception:"^4.2" -W --no-update
+
+    - name: Install Codeception 5 on PHP 8
+      if: matrix.php != '7.4'
+      run: composer require codeception/codeception:"^5.0" -W --no-update
+
     - name: Install dependencies
       run: composer install --prefer-dist --no-progress --no-interaction --no-suggest
 
     - name: Run test suite
-      run: php -l src/Codeception/Module/Cli.php
+      run: php vendor/bin/codecept run

codeception.yml

@@ -0,0 +1,20 @@
+namespace: Tests
+support_namespace: Support
+suites:
+    cli:
+        path: .
+        actor: CliTester
+        modules:
+            enabled:
+                - Asserts
+                - Cli
+        step_decorators: ~
+
+settings:
+    shuffle: true
+    lint: true
+paths:
+    tests: tests
+    output: tests/_output
+    support: tests/Support
+    data: tests/Support/Data

composer.json

@@ -1,7 +1,9 @@
 {
     "name": "codeception/module-cli",
     "description": "Codeception module for testing basic shell commands and shell output",
-    "keywords": [ "codeception" ],
+    "keywords": [
+        "codeception"
+    ],
     "homepage": "https://codeception.com/",
     "type": "library",
     "license": "MIT",
@@ -13,7 +15,8 @@
     "minimum-stability": "RC",
     "require": {
         "php": "^7.4 || ^8.0",
-        "codeception/codeception": "*@dev"
+        "codeception/codeception": "*@dev",
+        "codeception/module-asserts": "*"
     },
     "conflict": {
         "codeception/codeception": "<4.0"
@@ -26,4 +29,4 @@
     "config": {
         "classmap-authoritative": true
     }
-}
+}

src/Codeception/Module/Cli.php

@@ -45,6 +45,13 @@ public function _before(TestInterface $test): void
     public function runShellCommand(string $command, bool $failNonZero = true): void
     {
         $data = [];
+        /**
+         * \Symfony\Component\Console\Application::configureIO sets SHELL_VERBOSITY environment variable
+         * which may affect execution of shell command
+         */
+        if (\function_exists('putenv')) {
+            @putenv('SHELL_VERBOSITY');
+        }
         exec("{$command}", $data, $resultCode);
         $this->result = $resultCode;
         $this->output = implode("\n", $data);

tests/ShellVerbosityIsNotInheritedCest.php

@@ -0,0 +1,15 @@
+<?php
+
+
+namespace Tests\Cli;
+
+use Tests\Support\CliTester;
+
+class ShellVerbosityIsNotInheritedCest
+{
+    public function shellVerbosityIsNotInheritedFromCodeception(CliTester $I)
+    {
+        $I->runShellCommand('php ' . codecept_data_dir('check_verbosity.php'));
+        $I->seeInShellOutput('bool(false)');
+    }
+}

tests/Support/CliTester.php

@@ -0,0 +1,38 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Support;
+
+require_once __DIR__ . '/_generated/CliTesterActions.php';
+
+if (trait_exists(\Tests\_generated\CliTesterActions::class, false)) {
+    class_alias(\Tests\_generated\CliTesterActions::class, \Tests\Support\_generated\CliTesterActions::class);
+}
+
+/**
+ * Inherited Methods
+ *
+ * @method void wantToTest($text)
+ * @method void wantTo($text)
+ * @method void execute($callable)
+ * @method void expectTo($prediction)
+ * @method void expect($prediction)
+ * @method void amGoingTo($argumentation)
+ * @method void am($role)
+ * @method void lookForwardTo($achieveValue)
+ * @method void comment($description)
+ * @method void pause($vars = [])
+ *
+ * @SuppressWarnings(PHPMD)
+ */
+class CliTester extends \Codeception\Actor
+{
+    use _generated\CliTesterActions;
+
+    /**
+     * Define custom actions here
+     */
+}
+
+class_alias(CliTester::class, \Tests\CliTester::class);

tests/Support/Data/check_verbosity.php

@@ -0,0 +1,3 @@
+<?php
+
+var_dump(getenv('SHELL_VERBOSITY'));

tests/Support/_generated/.gitignore

@@ -0,0 +1,2 @@
+*
+!.gitignore

tests/_output/.gitignore

@@ -0,0 +1,2 @@
+*
+!.gitignore