Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code standards updated to PHP 7.1 #40

Merged
merged 2 commits into from
May 27, 2021
Merged

Code standards updated to PHP 7.1 #40

merged 2 commits into from
May 27, 2021

Conversation

TavoNiievez
Copy link
Member

  • The minimum version of PHP is now 7.1
  • Added strict types
  • Added return types
  • Added some typehints
  • Removed deprecated method persistEntity
  • Removed unnecessary qualifiers

@TavoNiievez TavoNiievez marked this pull request as ready for review May 13, 2021 02:40
Naktibalda
Naktibalda requested changes May 18, 2021
View reviewed changes
src/Codeception/Module/Doctrine2.php Outdated Show resolved Hide resolved
@TavoNiievez TavoNiievez merged commit 2c87912 into Codeception:master May 27, 2021
@TavoNiievez TavoNiievez deleted the return-types branch May 27, 2021 19:15
@TavoNiievez TavoNiievez added this to the 2.0.0 milestone Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naktibalda Naktibalda Naktibalda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TavoNiievez @Naktibalda