-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: uploaded files should have test
flag set to true
#26
Conversation
@fkupper Whoops, that was me. (here #7) I would like to apologize for the fact that the contribution guides are not so clear, I had yet to update them with respect to the I can solve all the doubts you have regarding the contribution guides in order to improve them in the process. But basically:
|
Co-authored-by: Tavo Nieves J <64917965+TavoNiievez@users.noreply.github.com>
This is why tests are important. I really wanted to add a test for this but it doesn't fit the
Please, no need for apologize! The guide is clear enough. What I mean is that the guide intends to test the module's methods and not the underlying code, therefore I did not see a place where the tests would fit.
⬆️ This is very clear from the guide, don't worry! ;) |
BTW, thanks for the effort of writing a proper reply with clear and meaningful content. 👏 |
Create a new test suite called |
Thank you! |
Tests added ✅ |
@fkupper I released your changes as version |
Thank you so much. |
The block of code fixing the issue Codeception/Codeception#3417 was remove when moving from laravel 5 module.
I do not know what was the reasoning behind it, but it breaks tests relying on the
test
flag being set totrue
.I did not add any tests as this change is not fitting your contributor's guide and it is unclear to me where to do this.