Update codebase to PHP 7.4 (#82)

Codeception · Nov 30, 2021 · 085c554 · 085c554
1 parent 4ed6ad5
commit 085c554
Show file tree

Hide file tree

Showing 11 changed files with 555 additions and 533 deletions.
diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
     "name":"codeception/module-webdriver",
     "description":"WebDriver module for Codeception",
     "keywords":["codeception", "browser-testing", "acceptance-testing"],
-    "homepage":"http://codeception.com/",
+    "homepage":"https://codeception.com/",
     "type":"library",
     "license":"MIT",
     "authors":[
@@ -19,7 +19,9 @@
     "minimum-stability": "RC",
 
     "require": {
-        "php": ">=5.6.0 <9.0",
+        "php": "^7.4 | ^8.0",
+        "ext-json": "*",
+        "ext-mbstring": "*",
         "codeception/codeception": "^4.0",
         "php-webdriver/webdriver": "^1.8.0"
     },

diff --git a/readme.md b/readme.md
@@ -1,4 +1,6 @@
-# WebDriver module for Codeception
+# Codeception Module WebDriver
+
+A WebDriver module for Codeception.
 
 [![Chrome Tests](https://github.com/Codeception/module-webdriver/actions/workflows/webdriver-chrome.yml/badge.svg)](https://github.com/Codeception/module-webdriver/actions/workflows/webdriver-chrome.yml)
 [![Chrome Headless Tests](https://github.com/Codeception/module-webdriver/actions/workflows/webdriver-chrome-headless.yml/badge.svg)](https://github.com/Codeception/module-webdriver/actions/workflows/webdriver-chrome-headless.yml) 
@@ -7,7 +9,7 @@
 ## Installation
 
 ```
-composer require --dev "codeception/module-webdriver"
+composer require "codeception/module-webdriver" --dev
 ```
 
 ## Documentation

diff --git a/src/Codeception/Exception/ConnectionException.php b/src/Codeception/Exception/ConnectionException.php
@@ -1,6 +1,11 @@
 <?php
+
+declare(strict_types=1);
+
 namespace Codeception\Exception;
 
-class ConnectionException extends \RuntimeException
+use RuntimeException;
+
+class ConnectionException extends RuntimeException
 {
 }
diff --git a/src/Codeception/Lib/Interfaces/ScreenshotSaver.php b/src/Codeception/Lib/Interfaces/ScreenshotSaver.php
@@ -1,4 +1,5 @@
 <?php
+
 namespace Codeception\Lib\Interfaces;
 
 interface ScreenshotSaver
@@ -10,7 +11,6 @@ interface ScreenshotSaver
      * $this->getModule('{{MODULE_NAME}}')->_saveScreenshot(codecept_output_dir().'screenshot_1.png');
      * ```
      * @api
-     * @param $filename
      */
-    public function _saveScreenshot($filename);
+    public function _saveScreenshot(string $filename);
 }
diff --git a/src/Codeception/Lib/Interfaces/SessionSnapshot.php b/src/Codeception/Lib/Interfaces/SessionSnapshot.php
@@ -1,4 +1,5 @@
 <?php
+
 namespace Codeception\Lib\Interfaces;
 
 interface SessionSnapshot
@@ -27,32 +28,28 @@ interface SessionSnapshot
      *      // saving snapshot
      *      $I->saveSessionSnapshot('login');
      * }
-     * ?>
      * ```
      *
-     * @param $name
      * @return mixed
      */
-    public function saveSessionSnapshot($name);
+    public function saveSessionSnapshot(string $name);
 
     /**
      * Loads cookies from a saved snapshot.
      * Allows to reuse same session across tests without additional login.
      *
      * See [saveSessionSnapshot](#saveSessionSnapshot)
      *
-     * @param $name
      * @return mixed
      */
-    public function loadSessionSnapshot($name);
+    public function loadSessionSnapshot(string $name);
 
     /**
      * Deletes session snapshot.
      *
      * See [saveSessionSnapshot](#saveSessionSnapshot)
      *
-     * @param $name
      * @return mixed
      */
-    public function deleteSessionSnapshot($name);
+    public function deleteSessionSnapshot(string $name);
 }