-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update population-geography sql files. #95
Conversation
Syncs with 2011 National Data Census.
Can you provide a few examples of the geographic locations whose names were changed as part of this? I would like to verify that this works with the current geojson and topojson files. Providing a list of half a dozen geographic locations whose names were changed would be useful. If the changes were only for local bodies, then examples for local bodies in different districts and provinces would be nice. If the changes were for districts as well, an example or two of changed districts would also be useful. For the name changes, were they only in the |
I have confirmed that total population now matches the population in the pre-federal version at https://nepalmap.org/profiles/country-NP-nepal. I have spot-checked districts, and the following districts also have matching populations.
|
I have navigated through the map, selecting a variety of local bodies without any problems so far. What I notice is that the "long name", the name that appears in the box on the map has been changed for all of the local bodies that I selected, and the map continues to work correctly. I would like to learn more about whether or not the shorter "name" was altered as well for any local bodies so that I can check them to make sure they also display correctly. |
Based on the issues #92, I was the one who recommended updating local bodies' name so that it will be easier for users to navigate and find their local bodies, and in this PR both the name and long_name are updated in geography.sql file. We are yet to update the GEO file and currently searching for the easiest way to update geojson and topojson files with the current geography table. Regarding the change, we can take an example of Rolpa district. Here is how the previous table looks like:
And here is the updated table with new local bodies name: (for reference: https://myrepublica.nagariknetwork.com/news/33282/)
Also there were many other similar kinds of spelling errors, for example:
But unfortunately, we haven't created a separate table for the changed local bodies name. If there are any problems with the display, I believe it will be because of the GEO file which is yet to be updated as per the “wazimap_geography” table. Do you have any recommendations on how we can do it, we kinda struggle on that part and @pratimakandel is currently exploring the QGIS and learning how to edit & update it. |
Thank you for the examples. They are useful. Based on the examples, here is what I have learned:
Based on this, it seems that the most important bit of information about each body is the geo code because it allows for matching data to places on the map. In my experience, the GEO files are some of the hardest things to work with in this project. It's hard to edit them. They are each one giant line of text, and figuring out how to adjust them can be difficult. In this case, since the geo codes have not changed and because we know which local bodies have changed names and what the changes are, it seems like it would be possible to write a script to go over the files and alter the names. I am curious about what might be best for "name", which is the value that shows up on hover. Will full names, like "Parivartan Rural Municipality" be unwieldy for hovers? Would using just "Parivartan" be acceptable? The "long_name" is what is searchable and is what is used in displays, like in the box with stats that shows on the map. One possibility would be to use a shortened name, like "Parivartan" or "Kathmandu" in the "name" field and the full, official name in the "long_name" field. Here are some examples showing incorrect hover texts. |
Thank you @cliftonmcintosh - using the short name at "name" field and official name in the "long_name" field is a nice idea, I will go ahead and prepare new sheet accordingly and ask @pratimakandel to update the geography.sql file again. Regarding the GEO file, we were trying to resolve issue #61 with the new update but it looks like it's very difficult and time-consuming. For a moment, we will go ahead and create a table of changed local bodies name so that we can write a script to go over the files and alter the names. |
Sorry, there is a problem with my latest commit "Update Geography SQL file". |
@cliftonmcintosh I have been playing around with the geojson files to understand how it operates. I accidentally pushed changes to my dev repo with the updated geography sql along with some changes in the local.geojson. I deleted the local.geojson file and uploaded the correct one from Code4nepal repo. Everything works perfectly! However please let me know if there is a better way to make a pull request that does not change the local.geojson file. |
I have a question. Are you saying that the local.geojson included in this PR is an updated file that should have changes you made in it? Or is it "the correct one from Code4nepal repo"? Are you trying to make a commit that does not change the local.geojson file? If so, I can try to provide some guidance for that. |
Sorry for the confusion, this PR's latest commit has the correct local.geojson from Code4Nepal Repo. And yes, I am trying to make a commit that does not change the local.geojson file at all. |
Thanks. Since Github says the local.geojson file that has been included here has changes I request that we figure out how to adjust this PR so that there are no changes to the local.geojson file, even if we think those changes might be safe. Here are some directions that should do that:
This should show one untracked file -- the file that you have just created, something like:
This should show something like:
You might also be able to use |
Replace local.geojson file with earlier one
@cliftonmcintosh |
Even though this change introduces a discrepancy between the SQL data and the map data, I think it is fine to go ahead and merge this update to the SQL data because the SQL data are more accurate. Subsequent changes to the map data should remove the discrepancy. |
This change has been deployed to beta.nepalmap.org |
Syncs with 2011 National Data Census.