Issue (#96) Update new/current local bodies name at TopoJSON and GeoJSON file #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd fixed geography.sql error
Updated new/current local bodies name at TopoJSON and GeoJSON file a…
pratimakandel
requested review from
nikeshbalami,
ravinepal and
cliftonmcintosh
|
Thank you very much for this update. Using the spreadsheet for name changes, I have spot-checked about 10% of the localities whose names have changed, and they all look good. |
|
Your updates have been deployed to https://beta.nepalmap.org. Thank you. |
|
@cliftonmcintosh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took @Crackjack advice and just created a basic find-replace bash script to update the local bodies names. I also found some errors with the geography.sql file, some of the districts cant open in the beta site ex. Baglung(Gandaki Province), Bara(Province 2)...etc. This pull request should fix geography.sql file issue.
While running the server, everything looks good. Please let me know if there is anything missing.