Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts do not have unique value for "post_title" column in the database "wp_posts" table #915

Closed
vytisbulkevicius opened this issue Jul 31, 2022 · 5 comments · Fixed by #916 or #932
Closed

Charts do not have unique value for "post_title" column in the database "wp_posts" table #915

vytisbulkevicius opened this issue Jul 31, 2022 · 5 comments · Fixed by #916 or #932
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@vytisbulkevicius
Copy link
Contributor

Description:

One of the clients communicated an interesting request that we hadn't encountered before.
He's using Advanced Custom Fields (ACF) plugin to build a custom solution where a chart can be assigned to a user via ACF. The problem that he's facing is that Charts are stored as Posts in the DB and this is how he gets a list of charts -
image

But then, in the dropdown of the results or charts appear with the same name:
image

This happens because in the database we save every chart with the same name for "post_title":
image

Can we have unique naming for chart here (could be ID of the chart) without breaking something how charts currently works?

Alternatives:

Try to guess which chart you want to select.

Reported here - https://secure.helpscout.net/conversation/1958630731/330707/
@vytisbulkevicius vytisbulkevicius added the enhancement Request to improve or optimize an existing feature or functionality in the project label Jul 31, 2022
girishpanchal30 added a commit that referenced this issue Aug 1, 2022
@girishpanchal30
Create unique chart title #915
3f35dac
@girishpanchal30 girishpanchal30 mentioned this issue Aug 1, 2022
Merged
@girishpanchal30 girishpanchal30 linked a pull request Aug 1, 2022 that will close this issue
Chart unique title #916
Merged
@girishpanchal30
Copy link
Contributor

Hey @vytisbulkevicius,

Can we have unique naming for chart here (could be ID of the chart) without breaking something how charts currently works?

Yes, I have created a unique title using title + ID using WordPress filter, Please check and let me know if you have an issue.

Thanks

@irinelenache
Copy link

@girishpanchal30 Tested and the enhancement seems to work fine 🚀

Found something else, it happens with the live version of Visualizer also, but maybe it can be fixed in this PR:

If i create a chart, make a copy of it and try to edit one of them (the initial chart or the copy), when i click on Save chart, the screen freezes and i have to refresh the page to make it work. I created a video to better outline the issue https://vertis.d.pr/s6P5Wm . If the problem needs more attention, i can create a new issue for it 👍

girishpanchal30 added a commit that referenced this issue Aug 1, 2022
@girishpanchal30
Fix redirect issue when edit clone chart #915
ac521a4
@girishpanchal30
Copy link
Contributor

@irinelenache Fixed above mentioned issue, Please check with the latest changes.

@irinelenache
Copy link

@girishpanchal30 Tested and the mentioned issue is fixed now, thank you 🚀

@vytisbulkevicius vytisbulkevicius mentioned this issue Aug 29, 2022
Merged
@vytisbulkevicius vytisbulkevicius linked a pull request Aug 29, 2022 that will close this issue
Release #932
Merged
vytisbulkevicius added a commit that referenced this issue Aug 30, 2022
@vytisbulkevicius
release: fixes
7584e7d 
- Fix update axis baseline color #925 
- Update more features images #926
- Fix update minor grid line field #924 
- Add new filter for container attributes #922 
- Fix axis data format issue #920 
- Chart unique title #915 
- Fix block back button issue #930 
- Userguide broken documentation link #918
pirate-bot pushed a commit that referenced this issue Aug 30, 2022
chore(release): 3.7.11
fe73598 
##### [Version 3.7.11](v3.7.10...v3.7.11) (2022-08-30)

- Fix update axis baseline color [#925](#925)
- Update more features images [#926](#926)
- Fix update minor grid line field [#924](#924)
- Add new filter for container attributes [#922](#922)
- Fix axis data format issue [#920](#920)
- Chart unique title [#915](#915)
- Fix block back button issue [#930](#930)
- Userguide broken documentation link [#918](#918)
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.7.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chart unique title Codeinwp/visualizer
Release Codeinwp/visualizer
4 participants
@vytisbulkevicius @pirate-bot @irinelenache @girishpanchal30