Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualizer 3.9.0 breaks with Polylang #960

Closed
todeveni opened this issue Nov 15, 2022 · 3 comments · Fixed by #963
Closed

Visualizer 3.9.0 breaks with Polylang #960

todeveni opened this issue Nov 15, 2022 · 3 comments · Fixed by #963
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@todeveni
Copy link
Contributor

Description:

Visualizer 3.9.0 added WPML support in ad22ce3, which breaks the plugin with Polylang, since Polylang registers icl_get_languages function for WPML compatibility.

Maybe some additional checks for $sitepress global that it's actually instanceof SitePress?

How to reproduce:

Install Visualizer 3.9.0. Install Polylang.

Expected behaviour:

Site loads with graphs.

Current behaviour:

Site doesn't load with graphs.

Call to a member function get_element_trid() on null
errfile:wp-content/plugins/visualizer/classes/Visualizer/Module/Frontend.php
errline:312

Technical info

  • WordPress version: 6.0.3
  • Plugin version: 3.9.0
@vytisbulkevicius
Copy link
Contributor

+1 https://secure.helpscout.net/conversation/2064385893/344129/

@vytisbulkevicius vytisbulkevicius added the bug This label could be used to identify issues that are caused by a defect in the product. label Nov 15, 2022
girishpanchal30 added a commit that referenced this issue Nov 15, 2022
@girishpanchal30
Fix PHP error when polylang plugin activated #960
7a6604d
@girishpanchal30 girishpanchal30 mentioned this issue Nov 15, 2022
Merged
girishpanchal30 added a commit that referenced this issue Nov 15, 2022
@girishpanchal30
e2e: fix invisible element error #960
60c1b89
@irinelenache
Copy link

@girishpanchal30 Checked with the linked PRs and the issue is fixed now 👍

@todeveni todeveni mentioned this issue Nov 16, 2022
Closed
@vytisbulkevicius vytisbulkevicius mentioned this issue Nov 17, 2022
Merged
@vytisbulkevicius vytisbulkevicius linked a pull request Nov 17, 2022 that will close this issue
Release #963
Merged
vytisbulkevicius added a commit that referenced this issue Nov 17, 2022
@vytisbulkevicius
release: fixes
031794e 
- Fixed PHP error when Polylang plugin is activated #960
pirate-bot pushed a commit that referenced this issue Nov 17, 2022
chore(release): 3.9.1
f148afb 
##### [Version 3.9.1](v3.9.0...v3.9.1) (2022-11-17)

- Fixed PHP error when Polylang plugin is activated [#960](#960)
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.9.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release Codeinwp/visualizer
4 participants
@todeveni @vytisbulkevicius @pirate-bot @irinelenache