Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing backup for existing files #76

Open
jankrloz opened this issue Jan 22, 2021 · 3 comments
Open

Missing backup for existing files #76

jankrloz opened this issue Jan 22, 2021 · 3 comments

Comments

@jankrloz
Copy link

There is not a disclaimer when you install dotly on a configured computer, the installation overwrites my existing .zshrc and replace them with the default template, I lost my configuration.

@gtrabanco
Copy link
Contributor

@rgomezcasas #152

gtrabanco added a commit to gtrabanco/dotSloth that referenced this issue Jul 12, 2021
* Now is different Sloth symlinks and user symlinks
* dot symlinks update use new dotbot.sh library to apply symlinks
* Fixed missing paths for gnutools in init-sloth.sh
* Fixed dot package add loop when try to install docpars or cargo packages
* Fixed no backup when installing Sloth (see CodelyTV#76)
* Added libraries (dotbot.sh and symlinks.sh) to parse dotbot yaml files in symlinks context
* Added python-yq recipe and dependency on dot core install
* Added some options for dot symlinks apply see --help
* Added function readarray in array.sh for those who are not running bash greather than version 4
* Changed mapfile for readarray in all scripts and libraries
* Added files::backup_move_if_path_exists in files.sh
* Added files::fzf that helps including Dotly/.Sloth core libraries and any other libraries in fzf --preview option
@xserrat
Copy link

xserrat commented Nov 20, 2021

Hi @gtrabanco ,

Is this issue fixed? I've just lost the whole config from my .zshrc... :'(

I think we should add a warning/alert in the README.md file informing about this issue and maybe a confirmation in the installer to inform that they'll lose the current configuration. What do you think @rgomezcasas ?

For whom with the same issue, here is a little help to restore the .zshrc based on an opened session with the lost configuration: https://superuser.com/questions/1043315/dumping-current-zshrc-from-terminal/1046861

@gtrabanco
Copy link
Contributor

gtrabanco commented Nov 21, 2021

It is solved in .Sloth but the PR was open for months and after no feedback, approval or reject I decided to use only my fork to make some improvements where it is this one between some other.

I also apply the new patchs and features to dotly there. It is quite complex because it is a good idea parse the dotbot files to know which files you have to do a backup.

@xserrat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants