feat: implement async commands. PaintCurrentUserAvatarCommandHandler example
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `paintCurrentUserAvatarCommand` requires to go outside the sandbox again returning back to the UI in order to interact with the DOM API to make a network request
… explicit about where they will be executed
…ore explicit about where they will be executed
…dapt to the Figma semantics
…n order to double it in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New menu command:
Result:
We also added
CancelCommandHandlertests in order to illustrate how we could do it despite the Figma SDK limitationsSee commit messages for further details