Apply the Docker builder pattern (multistage build) for the PHP Dockerfile #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for test environment arranger trying to create it inside the Docker container where it already exists. Ideal solution: Remove the environment arranger (further PR)
…kerfile * Move the PHP Dockerfile to the root directory. Why: Previously we were not able to apply the multistage approach because the PHP `Dockerfile` was in a subdirectory, so the `COPY composer.json composer.lock /app/` instruction could not find these files because they were not in the current `Dockerfile` context. Moving it to the root directory allow us to have the `composer.json` and `composer.lock` in the `Dockerfile` context
rgomezcasas
approved these changes
Oct 31, 2018
docker-compose.yml
Outdated
| @@ -15,7 +15,8 @@ services: | |||
| php: | |||
| container_name: codelytv-cqrs_ddd_php_example-php | |||
| build: | |||
| context: etc/infrastructure/php | |||
| context: . | |||
| dockerfile: Dockerfile-php | |||
There was a problem hiding this comment.
I would name it Dockerfile since it's our server (and would be the unique to be in the root)
…would be the unique to be in the root)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #61
Important: We've moved the PHP Dockerfile to the root directory. Why: Previously we were not able to apply the multistage approach because the PHP
Dockerfilewas in a subdirectory, so theCOPY composer.json composer.lock /app/instruction could not find these files because they were not in the currentDockerfilecontext. Moving it to the root directory allow us to have thecomposer.jsonandcomposer.lockin theDockerfilecontext