Add JS grades example #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgomezcasas
force-pushed
the
js-example
branch
from
71bd4a8
to
c85bc6b
Compare
rgomezcasas
force-pushed
the
js-example
branch
2 times, most recently
from
2124ed7
to
119697b
Compare
JavierCane
requested changes
Sep 21, 2020
rgomezcasas
force-pushed
the
js-example
branch
from
119697b
to
6b8ad6a
Compare
nuria-fl
reviewed
Sep 22, 2020
| let hasToIncreaseOneExtraPoint = false; | ||
|
|
||
| for (let [year, teachers] of Object.entries(this.allYearsTeachers)) { | ||
| if (!(this.yearToCalculate != year)) { |
There was a problem hiding this comment.
Not sure if it's intentional, but I see some comparisons use the strict operator, while others don't. I think most people are used to always stick to the strict comparison, but not a big issue anyway!
There was a problem hiding this comment.
This is one of the smells 😊🤘
rgomezcasas
force-pushed
the
js-example
branch
from
6b8ad6a
to
b881ba3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.