Caching users #29
Merged
Caching users #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntRepository resides in.
…nstead of just a userId field.
…ndition, so it just returned empty user list from the database.
…ey're not over half a day old.
…they're loaded from the API.
…actually be zero, since the users are missing all data.
… to have a profile image.
…lines each in the Profile class.
…can do that for us.
…arcelable stuff that didn't even work.
# Conflicts: # app/src/main/java/com/codemate/koffeemate/data/models/Profile.kt # app/src/main/java/com/codemate/koffeemate/di/components/AppComponent.kt
…almResults are unusable if the instance gets closed.
added 2 commits
February 6, 2017 08:54
…instances, instead of the real ones.
…to return something from realm after closing the instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary schema migrations & all that jive, that enables the users to be cached. This also has some code quality improvements, that should be in their own PR, but I just merged them into this one because I'm the dictator here.
Put this to action on Monday at work, and if it doesn't crash or do anything stupid (it shouldn't), merge to master.
Fixes #28.