[Rubocop] Use safe navigation (&.) instead of checking if an object e…

…xists before calling the method
Codeminer42 · Aug 23, 2017 · 9df7430 · 9df7430
1 parent 1112a5a
commit 9df7430
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/app/operations/note_operations.rb b/app/operations/note_operations.rb
@@ -15,7 +15,7 @@ def notify_users
       return if users_to_notify.none? || story.suppress_notifications
 
       notifier = Notifications.new_note(model.id, users_to_notify.map(&:email))
-      notifier.deliver if notifier
+      notifier&.deliver
     end
 
     def users_from_note

diff --git a/lib/tasks/i18n_missing_keys.rake b/lib/tasks/i18n_missing_keys.rake
@@ -31,12 +31,10 @@ class MissingKeysFinder
       I18n.available_locales.each do |locale|
         skip = false
         ls = locale.to_s
-        unless @yaml[ls].nil?
-          @yaml[ls].each do |re|
-            if key.match(re)
-              skip = true
-              break
-            end
+        @yaml[ls]&.each do |re|
+          if key.match(re)
+            skip = true
+            break
           end
         end