-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: expandend story estimate and type (V2). #419
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2fab5ed
to
e7aac1d
Compare
negreirosleo
reviewed
Dec 3, 2018
spec/javascripts/components/story/expanded_story/expanded_story_type_spec.js
Outdated
Show resolved
Hide resolved
negreirosleo
reviewed
Dec 3, 2018
app/assets/javascripts/components/story/ExpandedStory/ExpandedStoryType.js
Outdated
Show resolved
Hide resolved
e7aac1d
to
76b7ea2
Compare
76b7ea2
to
028f8ab
Compare
talyssonoc
requested changes
Dec 10, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They grow up so fast 😢
Mostly awesome job, just some changes to make it clearer 😄
app/assets/javascripts/components/story/ExpandedStory/ExpandedStoryEstimate.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/components/story/ExpandedStory/ExpandedStoryEstimate.js
Outdated
Show resolved
Hide resolved
spec/javascripts/components/story/expanded_story/expanded_story_estimate_spec.js
Outdated
Show resolved
Hide resolved
spec/javascripts/components/story/expanded_story/expanded_story_estimate_spec.js
Outdated
Show resolved
Hide resolved
spec/javascripts/components/story/expanded_story/expanded_story_estimate_spec.js
Outdated
Show resolved
Hide resolved
spec/javascripts/components/story/expanded_story/expanded_story_type_spec.js
Outdated
Show resolved
Hide resolved
spec/javascripts/components/story/expanded_story/expanded_story_type_spec.js
Outdated
Show resolved
Hide resolved
abnersajr
reviewed
Dec 10, 2018
That way is no necessary to reset story when it's canceled and columns will not reorder all stories in every change. Fix tests.
75d7d16
to
07a2793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for this two features:
Estimate option: 22718
Story Type: 22717