Skip to content

Commit

Permalink
delete performBatchUpdates
Browse files Browse the repository at this point in the history
	modified:   Example/JXBanner.xcodeproj/project.pbxproj
	modified:   Example/JXBanner/Demo/JXCustomVC.swift
	modified:   JXBanner.podspec
	modified:   JXBanner/Classes/Banner/Banner/JXBanner.swift
	modified:   ReleaseNote.md
  • Loading branch information
jiaxiang.tan committed Jul 29, 2021
1 parent cdc8871 commit 2fbe2b7
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 6 deletions.
4 changes: 4 additions & 0 deletions Example/JXBanner.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
6E07819923D5B13100FE8C60 /* JXMiddleTargetVC.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6E07819823D5B13100FE8C60 /* JXMiddleTargetVC.swift */; };
6E07819E23D5B17300FE8C60 /* JXMiddleTargetCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6E07819C23D5B17300FE8C60 /* JXMiddleTargetCell.swift */; };
6E07819F23D5B17300FE8C60 /* JXMiddleTargetCell.xib in Resources */ = {isa = PBXBuildFile; fileRef = 6E07819D23D5B17300FE8C60 /* JXMiddleTargetCell.xib */; };
6ED96CCF26B2816300A186BB /* ReleaseNote.md in Resources */ = {isa = PBXBuildFile; fileRef = 6ED96CCE26B2816300A186BB /* ReleaseNote.md */; };
/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
Expand Down Expand Up @@ -101,6 +102,7 @@
6E07819823D5B13100FE8C60 /* JXMiddleTargetVC.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = JXMiddleTargetVC.swift; sourceTree = "<group>"; };
6E07819C23D5B17300FE8C60 /* JXMiddleTargetCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = JXMiddleTargetCell.swift; sourceTree = "<group>"; };
6E07819D23D5B17300FE8C60 /* JXMiddleTargetCell.xib */ = {isa = PBXFileReference; lastKnownFileType = file.xib; path = JXMiddleTargetCell.xib; sourceTree = "<group>"; };
6ED96CCE26B2816300A186BB /* ReleaseNote.md */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = net.daringfireball.markdown; name = ReleaseNote.md; path = ../ReleaseNote.md; sourceTree = "<group>"; };
86DD0217E9DE21DAB1A6418E /* JXBanner.podspec */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text; name = JXBanner.podspec; path = ../JXBanner.podspec; sourceTree = "<group>"; xcLanguageSpecificationIdentifier = xcode.lang.ruby; };
A8BAC75A289C5E5883552C0B /* README.md */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = net.daringfireball.markdown; name = README.md; path = ../README.md; sourceTree = "<group>"; };
B37FA8DFCA403B9BCA5A97D5 /* LICENSE */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text; name = LICENSE; path = ../LICENSE; sourceTree = "<group>"; };
Expand Down Expand Up @@ -231,6 +233,7 @@
607FACF51AFB993E008FA782 /* Podspec Metadata */ = {
isa = PBXGroup;
children = (
6ED96CCE26B2816300A186BB /* ReleaseNote.md */,
86DD0217E9DE21DAB1A6418E /* JXBanner.podspec */,
A8BAC75A289C5E5883552C0B /* README.md */,
B37FA8DFCA403B9BCA5A97D5 /* LICENSE */,
Expand Down Expand Up @@ -390,6 +393,7 @@
6E07819F23D5B17300FE8C60 /* JXMiddleTargetCell.xib in Resources */,
1F41C64B2331D9AD00B83DC4 /* 11.jpg in Resources */,
6E06070F24174BBC00260BD9 /* mp4_1.jpg in Resources */,
6ED96CCF26B2816300A186BB /* ReleaseNote.md in Resources */,
1F41C6482331D9AD00B83DC4 /* 12.jpg in Resources */,
1F41C6492331D9AD00B83DC4 /* 9.jpg in Resources */,
6E06070E24174BBC00260BD9 /* mp4_4.jpg in Resources */,
Expand Down
6 changes: 5 additions & 1 deletion Example/JXBanner/Demo/JXCustomVC.swift
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,11 @@ class JXCustomVC: UIViewController {
}

override func touchesBegan(_ touches: Set<UITouch>, with event: UIEvent?) {
linearBanner.scrollToIndex(3, animated: false)
// linearBanner.scrollToIndex(3, animated: false)
pageCount = 1
converflowBanner.reloadView()
linearBanner.reloadView()
customBanner.reloadView()
}

deinit {
Expand Down
2 changes: 1 addition & 1 deletion JXBanner.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

Pod::Spec.new do |s|
s.name = 'JXBanner'
s.version = '0.3.4'
s.version = '0.3.5'
s.summary = 'A multifunctional framework for banner unlimited rollover diagrams'

# This description is used to generate tags and improve search results.
Expand Down
8 changes: 4 additions & 4 deletions JXBanner/Classes/Banner/Banner/JXBanner.swift
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,10 @@ extension JXBanner {
params.cycleWay = .skipEnd
}
placeholderImgView.isHidden = pageCount > 0
collectionView.performBatchUpdates {[weak self] in
self?.collectionView.reloadData()
} completion: { [weak self] _ in
self?.reinitializeIndexPath()
collectionView.reloadData()
collectionView.layoutIfNeeded()
DispatchQueue.main.async {
self.reinitializeIndexPath()
}
}

Expand Down
7 changes: 7 additions & 0 deletions ReleaseNote.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,10 @@
* **commit**: `f294d0ae68d7c`
* **主要更新**
* 修复:在系统版本低的设备上会触发闪退的情况。(断点分析为collectionView未刷新完成,调用scrollToItem导致。)

## 0.3.5
* **日期**:2020-07-29
* **tag**: 0.3.5
* **commit**: `f294d0ae68d7c`
* **主要更新**
* 修复:使用performBatchUpdates获取刷新结束方式出现崩溃。

0 comments on commit 2fbe2b7

Please sign in to comment.