Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagonal line on slides renders backwards on score line break #1045

Closed
1 task done
jonaro00 opened this issue Nov 20, 2022 · 0 comments · Fixed by #1053
Closed
1 task done

Diagonal line on slides renders backwards on score line break #1045

jonaro00 opened this issue Nov 20, 2022 · 0 comments · Fixed by #1053
Assignees
Labels
area-rendering Everything related to the rendering platform-all Affects all platforms 🕷️ type-bug state-accepted This is a valid topic to work on.

Comments

@jonaro00
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When a slide happens to appear at the end of a bar at a line break, the visual line is rendered incorrectly:

image

It happens on 1.2.2, 1.2.3, and the current 1.3 alpha.
Happens for both {ss} and {sl} slides.

Expected Behavior

The slide notation line renders forward towards the end of the score line with the correct angle.

Steps To Reproduce

Write and render a piece with a slide similar to the one pictured above and adjust the viewport until the slide appears at the end of a score line.

Link to jsFiddle, CodePen, Project

No response

Found in Version

1.2

Platform

Web

Environment

- **OS**: Windows 10
- **Browser**: Happens on latest Brave (Chromium) and Firefox

Anything else?

No response

@jonaro00 jonaro00 added the state-needs-triage Bug not triaged yet. label Nov 20, 2022
@Danielku15 Danielku15 added 🕷️ type-bug area-rendering Everything related to the rendering state-accepted This is a valid topic to work on. platform-all Affects all platforms and removed state-needs-triage Bug not triaged yet. labels Nov 26, 2022
@Danielku15 Danielku15 added this to Done in AlphaTab 1.3 Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-rendering Everything related to the rendering platform-all Affects all platforms 🕷️ type-bug state-accepted This is a valid topic to work on.
Projects
Status: Done
AlphaTab 1.3
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants